Show default workspace rooms

[neil-marcellini]

Details

Make the default #announce and #admins rooms show up immediately after creating a new workspace. Also, when the workspace is deleted update the room names to show that they have been deleted. For more context see the design doc here.

Deleting workspaces currently doesn't work on IOS and Android. See the issue here.

Fixed Issues

$ #5946

Tests

1. Log in with a brand new account
2. Create a workspace from the green plus button at the bottom left.
3. Check for the #announce and #admins rooms in the left hand navigation.

For all platforms except iOS and Android:

4. Go to Settings > Workspace
5. Click the three dots in the header and select delete workspace, and confirm delete.
6. Confirm that the room names change to #announce (deleted) and #admins (deleted)

• Verify that no errors appear in the JS console

QA Steps

Same as tests above.

• Verify that no errors appear in the JS console

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[nickmurray47]

Following QA steps, seems like creating a new workspace has doubled the default workspace rooms.

[neil-marcellini]

Following QA steps, seems like creating a new workspace has doubled the default workspace rooms.

@nickmurray47
Based on the design doc I think that is the expected behavior. Each work space gets its own #announce and #admins rooms. You can see in the subtext which workspace they belong to. I do think it's a bit clunky to have multiple default rooms especially if they both have a default workspace name, but we can always change that down the road. How do you think that should be handled?

I also edited the testing steps to clarify that a brand new account should be used and one workspace should be created with the green plus button.

[nickmurray47]

ok, thanks for the explanation @neil-marcellini! The code lgtm as far as I can tell but also going to loop in the design doc author just to confirm this is the expected behavior.

I do think it's a bit clunky to have multiple default rooms especially if they both have a default workspace name

Yeah, so there's going to be default rooms for the user when they sign up which will have the same names as the default rooms for the first workspace that's created? It was confusing to me on the first run-through because I'd expect the default rooms for a user to not exist at all then, i.e. the default rooms should only be there once a workspace is created.

[neil-marcellini]

Yeah, so there's going to be default rooms for the user when they sign up which will have the same names as the default rooms for the first workspace that's created? It was confusing to me on the first run-through because I'd expect the default rooms for a user to not exist at all then, i.e. the default rooms should only be there once a workspace is created.

When I make new accounts there are no default rooms and no workspace until you press the button to create a workspace. Could you please test again?

[yuwenmemon]

Yeah @nickmurray47 I would guess those default rooms are from some other corporate policy that account has open. They're not getting created with new accounts, right?

[nickmurray47]

When I make new accounts there are no default rooms and no workspace until you press the button to create a workspace. Could you please test again?

Interesting, will re-test again and see if there's any difference. This was with a brand-new account so would assume it was not under any old policies.

[nickmurray47]

re-tested and QA worked well!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[mvtglobally]

@neil-marcellini Should it be tested on All platforms?

[OSBotify]

🚀 Deployed to staging by @nickmurray47 in version: 1.1.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅