[HOLD for payment 2022-03-02] IPAD - Payment - Missing PayPal account when trying to delete it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app and login
2. Open your settings
3. Open the "Payments" page
4. Tap my PayPal payment
5. Tap Delete

Expected Result:

PayPal account should displayed after tap on Delete

Actual Result:

Missing PayPal account when trying to delete it

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS - IPAD

Version Number: 1.1.31.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[danieldoglas]

I agree that that's strange. Should show the info that's being deleted.

[MelvinBot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[NicMendonca]

Job posting: https://www.upwork.com/jobs/~0111d2f55cd83f6ef8

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ahmdshrif]

Proposal

will edit this line to be :-

App/src/pages/settings/Payments/PaymentsPage.js

Line 293 in c8d47a0

{this.props.isSmallScreenWidth && (

to

 {(this.props.isSmallScreenWidth || this.props.isMediumScreenWidth) && ...

update :
I think we need to make this also for big screen on native because in native the Popover come from button all time .
so I suggest to be like this : -

      {(Platform.OS !== 'web' || this.props.isSmallScreenWidth) && (

[parasharrajat]

@ahmdshrif 's proposal looks good.

cc: @thienlnam

🎀 👀 🎀 C+ reviewed

[thienlnam]

@NicMendonca Could you please hire @ahmdshrif for the job? 🟢

[NicMendonca]

@parasharrajat don't forget to apply to the job as well for C+. Thanks!

[NicMendonca]

Not overdue. Latest update here

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[thienlnam]

Changes are merged, awaiting regression period for payment

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Missing PayPal account when trying to delete it  #7571
• Fix: Missing PayPal account when trying to delete it  #7571

If no regressions arise, payment will be issued on 2022-03-02. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[NicMendonca]

paid!