Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report icon logic for newly created policy rooms #7252

Merged
merged 6 commits into from
Jan 25, 2022

Conversation

TomatoToaster
Copy link
Contributor

@TomatoToaster TomatoToaster commented Jan 14, 2022

@deetergp, please review when you get the chance.
CC: @neil-marcellini for help in testing this out on iOS/android and providing screenshots!

Details

Fixes bug that causes newly created policy rooms to crash when you click on their details. Since the rooms have

Fixed Issues

$ #7182
$ #7055
$ #7262

Tests/ QA Steps

  1. Log into NewDot with an account that has a workspace or create a workspace using the plus on the bottom left. Make sure you are the only person in the workspace.
  2. Using the same plus on the bottom left, choose New Room. Fill in the options in the modal and after the new room is created, verify that you see the couch icon for the room after it is created:
    image
  3. Click on that icon and verify you can access the room details like in the screenshots below. The room's settings should also be accessible.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web/ Mobile Web

image
image

iOS

image

Android

image

@TomatoToaster TomatoToaster self-assigned this Jan 14, 2022
@TomatoToaster TomatoToaster marked this pull request as ready for review January 21, 2022 23:22
@TomatoToaster TomatoToaster requested a review from a team as a code owner January 21, 2022 23:23
@MelvinBot MelvinBot requested review from deetergp and removed request for a team January 21, 2022 23:23
@deetergp
Copy link
Contributor

LGTM

@deetergp deetergp merged commit 4936dfb into main Jan 25, 2022
@deetergp deetergp deleted the amal-ucpr-fix-new-room branch January 25, 2022 22:17
@botify
Copy link

botify commented Jan 25, 2022

@deetergp looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@deetergp
Copy link
Contributor

The tests were passing. Not sure why it got flagged. Removing the Emergency label.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.33-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants