Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Chat - Size of text cursor is smaller when returning to any chat via browser back button #39303

Closed
1 of 6 tasks
lanitochka17 opened this issue Mar 29, 2024 · 47 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 29, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Start chat
  3. Create a group chat
  4. Split bill in the group chat
  5. Click on the split preview > Click any split member > Click Message
  6. In 1:1 DM, click on the IOU preview
  7. Click on the header subtitle to return to 1:1 DM
  8. Click browser back button until app returns to the group chat in Step 3

Expected Result:

The size of text cursor will remain the same when returning to group chat via browser back button

Actual Result:

The size of text cursor is smaller when returning to group chat via browser back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6432037_1711744193996.20240330_042506.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e868dd4a424eb130
  • Upwork Job ID: 1776300146755960832
  • Last Price Increase: 2024-04-05
  • Automatic offers:
    • paultsimura | Reviewer | 0
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@lanitochka17
Copy link
Author

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@marcaaron
Copy link
Contributor

Seems possibly more related to markdown changes.

@marcaaron
Copy link
Contributor

@thienlnam I asked for a re-test to see. It kinda feels like this would be broken everywhere (sorry if I end up wrong on that hunch).

@thienlnam
Copy link
Contributor

Definitely possible - I'll add it to the main tracking list. But seems pretty harmless and I don't think needs to be a blocker

@marcaaron
Copy link
Contributor

Cool. If you are not passionate about it. Then I'm gonna pop the label off.

@marcaaron marcaaron removed their assignment Mar 29, 2024
@marcaaron marcaaron added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Mar 29, 2024
Copy link

melvin-bot bot commented Mar 29, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@marcaaron
Copy link
Contributor

p.s. confirmed with QA that this is not limited to Group Chats.

@dylanexpensify
Copy link
Contributor

@quinthar heads up, I added this to vip-vsb, but with LOW given it's lack of impact on usability. LMK if you disagree!

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@thienlnam thienlnam added the External Added to denote the issue can be worked on by a contributor label Apr 5, 2024
@thienlnam thienlnam self-assigned this Apr 5, 2024
@melvin-bot melvin-bot bot changed the title Chat - Size of text cursor is smaller when returning to group chat via browser back button [$250] Chat - Size of text cursor is smaller when returning to group chat via browser back button Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e868dd4a424eb130

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@nkdengineer
Copy link
Contributor

@BartoszGrajdek @paultsimura this PR is ready for preview.

Copy link

melvin-bot bot commented Apr 12, 2024

@paultsimura @thienlnam @dylanexpensify @nkdengineer this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@dylanexpensify
Copy link
Contributor

PR is merged Mel! Waiting for payment day

@paultsimura
Copy link
Contributor

Waiting for payment day

I believe we still need a PR to bump the react-native-live-markdown version in the App, right @nkdengineer?

@dylanexpensify
Copy link
Contributor

Ah nice, thanks @paultsimura! 👍

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 15, 2024
@nkdengineer
Copy link
Contributor

@paultsimura this PR is ready for preview.

@paultsimura
Copy link
Contributor

This was deployed to production on April 22, due payment 2024-04-29

@dylanexpensify
Copy link
Contributor

dylanexpensify commented Apr 29, 2024

Payment summary:

Please apply or request!

@BartoszGrajdek
Copy link
Contributor

Hi! Can we get this issue closed? 😄 I'm trying to clean up the Live Markdown tracking issue right now :)

@thienlnam
Copy link
Contributor

thienlnam commented May 13, 2024

We don't close issues until we get them paid out - but we can remove this from the tracking issue

EDIT: I went ahead and cleaned up the main tracking issue here #36071

@dylanexpensify
Copy link
Contributor

bump @nkdengineer!

@nkdengineer
Copy link
Contributor

Hi @dylanexpensify, sorry for the delay, I've applied to the job https://www.upwork.com/jobs/~01e868dd4a424eb130

@dylanexpensify
Copy link
Contributor

no worries, thanks!!

@dylanexpensify
Copy link
Contributor

offer sent!

@nkdengineer
Copy link
Contributor

Hi @dylanexpensify, this issue was created on Mar 30, and according to this announcement, issues created prior to the announcement date Apr 4 will remain the original price ($500).

If that's correct, could you help update the GH title and offers, thanks 🙇

@paultsimura
Copy link
Contributor

@dylanexpensify in addition to @nkdengineer's comment above, it was quite a complex task involving an upstream fix in the Live Markdown package, so that note makes sense to me. WDYT?

@dylanexpensify
Copy link
Contributor

Ah, thanks for the catch, agree. Updated offer, and will pay out $500 in Upwork

@paultsimura
Copy link
Contributor

I've just applied for the job as well, thanks.

@dylanexpensify
Copy link
Contributor

sounds great!

@paultsimura
Copy link
Contributor

@dylanexpensify what's the payout plan on this? The payment day was a month ago, 2024-04-29

@dylanexpensify
Copy link
Contributor

@paultsimura paid last week! But just sent bonus along!

@dylanexpensify
Copy link
Contributor

@nkdengineer waiting for you to accept offer!

@nkdengineer
Copy link
Contributor

@dylanexpensify I accepted the offer. But the offer was for $250 so I guess a bonus of $250 will be sent too.

Thanks 🙇

@dylanexpensify
Copy link
Contributor

Correct! all done btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

7 participants