Handle case element height equal zero #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
nkdengineer
changed the title
6 tasks
|
@nkdengineer Thanks for the PR! We'll review it shortly |
|
I have read the CLA Document and I hereby sign the CLA |
|
Reviewing! 👀 |
BartoszGrajdek
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
LGTM! 🚀
cc @tomekzaw please merge this once you think we can safely upgrade the version of react-native-live-markdown in Expensify 🙏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently, we didn't check if the height is positive before returning the value. The height could be 0 if the parent element was not fully rendered in the DOM yet.
So on layout change, when we use the method to get the element height here to use as maxHeight, we're getting 0 as the height
To fix this: if the height is 0, we should return auto as the height
This is similar to the logic when numberOfLines is not defined here . There's a bug there also, the condition after || will never be triggered, it should be
styles.height ? '${styles.height}px' : 'auto'.Related Issues
Expensify/App#39303
Manual Tests
Linked PRs