Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIGH: [Live Markdown] Tracking Live Markdown Issues #36071

Closed
thienlnam opened this issue Feb 7, 2024 · 24 comments
Closed

HIGH: [Live Markdown] Tracking Live Markdown Issues #36071

thienlnam opened this issue Feb 7, 2024 · 24 comments
Assignees
Labels

Comments

@thienlnam thienlnam added the Weekly KSv2 label Feb 7, 2024
@thienlnam thienlnam self-assigned this Feb 7, 2024
@tomekzaw
Copy link
Contributor

tomekzaw commented Feb 7, 2024

Please assign me for visibility

@tgolen
Copy link
Contributor

tgolen commented Feb 9, 2024

I'm bumping up the priority of this since several of the reported bugs are deploy blockers. I recommend reverting the LiveMarkdown PR, fixing the bugs that have been reported, and then trying again.

Copy link

melvin-bot bot commented Feb 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 16, 2024

@tomekzaw, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tomekzaw
Copy link
Contributor

Working on it

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 16, 2024
Copy link

melvin-bot bot commented Feb 20, 2024

@tomekzaw, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tomekzaw
Copy link
Contributor

Working on it

Copy link

melvin-bot bot commented Feb 26, 2024

@tomekzaw, @thienlnam Huh... This is 4 days overdue. Who can take care of this?

@tomekzaw
Copy link
Contributor

Working on it

@tylerkaraszewski
Copy link
Contributor

@thienlnam - shoudl we move #39275 to BLOCKING DEPLOY or should we remove the deploy blocker from that issue?

@thienlnam
Copy link
Contributor Author

I think we can remove the blocker from that issue, seems like that just came out as well

@tylerkaraszewski
Copy link
Contributor

Oops, I had linked the wrong issue, I meant #39263, but that's been added to the deploy blocker section. Thanks!

@tylerkaraszewski
Copy link
Contributor

@thienlnam I got tagged for another deploy blocker that might be related: #39301

I don't know if this is severe enough to be a deploy blocker. Thoughts?

@thienlnam
Copy link
Contributor Author

Ah yeah definitely doesn't look like it needs to block deploy, I've added it above as part of MED

@bernhardoj
Copy link
Contributor

Hi, I found an issue with the live markdown on the web. The autoFocus prop of the composer seems not working. I tried setting it to false but the composer is still auto-focused.

I can reproduce it with this minimal code:
<RNMarkdownTextInput autoFocus={false} selection={{start: 0, end: 0}}/>

If there is a selection prop, the input will always be auto-focused. If I remove this live markdown source code, then the issue is gone.

Copy link

melvin-bot bot commented Apr 2, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@slafortune
Copy link
Contributor

Adding this issue as well - Chat- Nested quotes disappear when editing if different levels of quotes are present

@twisterdotcom
Copy link
Contributor

One more to add:

@thienlnam
Copy link
Contributor Author

We're still chugging along - almost done with all critical and highs

@thienlnam
Copy link
Contributor Author

SWM is OOO this week, we're still chugging through

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@melvin-bot melvin-bot bot added the Overdue label May 10, 2024
@thienlnam
Copy link
Contributor Author

Just cleaned up the tracking issue, the list is dwindling!

@thienlnam
Copy link
Contributor Author

Closing this! We've worked through all the critical issues, I think every issue from here on out can just be addressed independently. We're still working through #39518 but there's no longer a need for this main tracking issue

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

7 participants