Deploy Checklist: New Expensify 2024-02-02

[github-actions]

Release Version: 1.4.36-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add unread notifications to the LHN #28
• Keyboard hides input on mobile #45
• Channels with lots of messages freak out the scrollbars #46
• Always merge the report into the store, in case there is data already… #49
• Long comments get cut off the view #52
• Need to implement HTML rendered comments so we get styling #53
• Show a tab indicator when there are any unread messages #54
• Allows text comments to wrap #56
• Improve the scrolling with ScrollView #57
• Spinner left in the middle of the messages + dupe message  #58
• Fix comments #59
• Add image to LHN #60
• Load the file from a local resource #61
• Implement the new layout #62
• Scroll to show new comments #63
• fix private note code paste issue #32971
• [Wave 8] Ideal nav  #33280
• fix: items in workspace member invite list not occupying full width #34197
• Live Markdown Preview #34292
• feat: Integrate report fields with backend #34483
• Fix StartChat screen transition stuttering #34495
• feat: implement useArrowKeyFocusManager in EmojiPickerMenu #34581
• [TS migration] Migrate 'SettingsSecurityCloseAccount' page to TypeScript #34718
• fix: Selecting last possible member to group hides selected members. #34847
• Delete docs/articles/expensify-classic/getting-started/Security.md #34922
• 20354 task assignees list refactor #34978
• Add tap to focus and fix orientation #35014
• Fix split bill participant option select circle outline #35028
• Implement billable for split bill #35125
• Rectify the background delay issue by incorporating a transition #35215
• Fix/34434 #35218
• fix: After deleting task report is bolded in LHN and action is highlighted in report #35252
• Update redirects.csv #35265
• fix show more button #35281
• Only display one error message #35291
• Fix - Able to save phone number starting from = not + via WS Bank account connection #35293
• Fix/34994: Selected contact not move to top #35317
• [NoQA] [TS migration] Migrate rn-fetch-blob mock #35322
• feat: Persist the latest selected payment option #35327
• [NoQA] Change navigation mock in perf tests for SignInPage #35469
• Show corporate card transactions as Card in the preview #35488
• [HelpDot] Add information box #35522
• fix base url not showing for leave messages + minor refactoring #35525
• Use new lastActorDisplayName to display alternate text for room invite actions in LHN #35527
• [NoQA] Revert "[NoQA] Enable and refactor ReportScreen perf tests" #35545
• [NoQA] dev: fix e2e test by fixing writing inputs to env file #35546
• [NO QA] use buildAndroidE2EAPK composite action from main #35555
• [No QA] Improve Google Sign In documentation #35595
• [CP Staging] Fix a type in a prop name #35622
• Revert "20354 task assignees list refactor" #35659
• Setting GTM script to run on staging and adding nonce-random-value #35670
• [CP Staging] Use keyForList in OptionsSelector's isSelected logic #35770
• [CP Staging] fix: wait for navigation ready state before signing in #35827
• fix: sign-in here navigating to abracadabra page #35850
• Fix crash when tapping device back button to return from thread #35852

Deploy Blockers:

• [$500] [Wave Collect] [Ideal Nav] Workspace switcher - "Expensify" and workspace are ticked when returning from workspace [Payment due March 6] #35680
• [HOLD for payment 2024-02-19] [$500] [Wave 8][Ideal Nav] Workspace - Workspace is opened with 3-dot menu when long clicking and dragging over options #35681
• [HOLD for payment 2024-02-26] [$250] Workspace switcher - No tooltip when hovering over + button next to Workspaces #35683
• [$500] Web - Unable to upload Desktop App from website. Error 1102 displayed #35684
• [$125] Workspace switcher - Workspace dropdown button is hardly visible when hovering over it #35686
• [$500] Web - Preferences, Security, About, Workspaces animations are missing #35687
• Sections - Cards on the right hand page are left aligned instead of centered #35688
• [$500] Theme - App returns to main chat instead of previous page when returning from changing theme #35689
• PAY on 06/03 - [$500] [Wave Collect] [Ideal Nav] Workspace - Workspace is not clickable after returning from error page #35690
• [$500] Workspace - Tooltip is at the center instead of above display name #35691
• [$500] Workspace - Member list blinks briefly after inviting member to the workspace #35692
• Expense - Unable to save report title for workspace expense #35694
• [Wave 8] [Ideal Nav] Workspace - Workspace avatar switches from one to another when creating a new workspace #35695
• [HOLD 35626][$500] Chat - User redirected to LHN instead of chat after going back from task #35697
• IOU - System message shows "You renamed this room" after renaming IOU report #35698
• IOU - System message shows "You renamed this room" after renaming IOU report #35699
• Group - All recents users selected when clicking on "Add to group" #35701
• [Payment 2/21] [$500] [Wave 8] [Ideal Nav] WS - When deleting a WS offline, it is not crossed out #35702
• Settings - Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen #35703
• [$500] [HOLD for payment 2024-02-14] mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page #35720
• [$500] Wallet - "Delete Bank Account" button is positioned incorrectly #35722
• Bank Account - From Additional details page, tapping back button user directed to home page (LHN) #35723
• [$125] Android - Login - Status bar on login screen has black background on launch #35724
• Web - Login - Animation missing & Welcome message overlapping with menu options in login page #35726
• [$500] Workspace switcher - Search result is not highlighted when navigating via up and down key #35727
• [HOLD for payment 2024-02-14] [$125] Web - Profile icon and wrench at the bottom have the same tooltips #35728
• Status - Inconsistent behavior when closing status RHP #35729
• IOU - App resumes in IOU flow when killing app in confirmation page and relaunching app #35730
• [HOLD for payment 2024-02-26] [$500] Workspace - Clicking on avatar of invited workspace does not open avatar in full screen view #35731
• [$500] Web - Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page #35732
• Workspace - Create new workspace button does not response #35733
• Bank Account - User navigates to LHN when click back from Plaid page #35736
• Android – Back button redirect to LHN from IOU report preview in WS and unable to open WS chat #35738
• [$250] Tooltip - Search tooltip overlaps workspace name and chats #35739
• [HOLD for payment 2024-02-14] [$500] Login - Blank screen and infinite spinner when logging in using magic link #35745
• Bank account - Animation in One moment page is not displayed #35747
• Login - Onboarding modal not displayed for new account creation #35748
• [$250] Profile - No spacing between zoom/rotate toolbar & save button in edit photo page #35749
• Chat - When clicking "Go back to home page" user redirected to Workspaces #35750
• [$500] [HOLD for payment 2024-02-20] LHN - User navigated on Workspaces listing page when tapped on the settings tab in bottom #35752
• [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate away from Profile page using the back button #35753
• [HOLD Simplified collect] [$500] Workspace - Right hand page reloads when clicking Connect bank account #35754
• [HOLD for payment 2024-02-20] [$500] LHN - User navigated on the workspace overview page when created workspace #35755
• Workspace - Workspace owner is empty when created on one device and viewed on another device #35757
• [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate on the account settings page #35758
• [HOLD for payment 2024-02-20] [$500] LHN - Workspace announce chat opened when selected workspace on "Choose workspace" page #35759
• [HOLD for payment 2024-02-22] [$250] Workspace - Workspace highlighted member blinks when check/uncheck mark #35761
• [Awaiting Payment March 20th] [$500] Report - The conversation scrolls to the beginning when you open the settings menu #35763
• [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page #35764
• [HOLD for payment 2024-02-14] [$500] Chat - App crashes when tapping device back button to return from thread #35765
• [$500] Workspace-Some workspaces are shown in bold and some not #35766
• [$500] IOU-In expense report page, title saved is not shown. #35767
• [$500] Workspace - The default room opening after creating a workspace is #announce #35771
• WS Members - 'Back' leads to invite members page instead of Settings after delete added user #35776
• [HOLD for payment 2024-02-20] [$250] Profile - Error message when loading User / WS avatar has incorrect dimensions and position #35777
• [HOLD for payment 2024-02-14] [$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page. #35782
• Workspace - Workspace name is not displayed under cards, Invoices title. #35783
• [HOLD for payment 2024-03-20] [$500] Workspace - Title with /Chats and /Settings is not aligned properly with minimum font size #35785
• Text in the composer is very small when device font size is minimum #35787
• [$500] Workspace - Unable to open settings on a policy disabled account #35802
• [HOLD for payment 2024-02-20] [$500] IOU - From link in header show "IOU" instead of <User owes $XX> in request page #35803
• [HOLD for payment 2024-02-14] [$500] New Workspace button does not work #35820
• iOS - URLs are hyperlinked instead of hyperlink text when edit message #35831
• [HOLD for payment 2024-02-26] [$500] Expense - "Recent" and "All" appear in report field selection list when there is no result #35832
• The hover effect animation is not functioning properly on the Bank Account in workspace settings #35839
• [HOLD for payment 2024-04-15] [$500] Expense - Item in report list is not highlighted and list cannot be navigated with keyboard #35843

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[mvtglobally]

@francoisl @mountiny Has the build go through properly? I see some really old PRs in the checklist

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.36-0 🚀

[mountiny]

All ready @mvtglobally

[luacmartins]

Checked off #35683. Demoted to NAB.

[blimpich]

Checking off #35690, demoting.

[neil-marcellini]

Checking off [HOLD 35626][$500] Chat - User redirected to LHN instead of chat after going back from task, NAB

[dangrous]

Checking off #35681, demoting.

[amyevans]

Demoting #35680

[luacmartins]

Demoting #35728. Checked off

[luacmartins]

Demoting #35686. Checked off.

[luacmartins]

Demoted #35724. Checked off.

[francoisl]

Demoted #35722 and tagged the design team in Slack to confirm if we need to change anything

[blimpich]

#35733 is a dupe. Closed issue and checked off.

[francoisl]

#35731 was demoted, checking it off
#35723 is a dupe goBack issue, closed
#35694 was demoted, checking off
#35736 was demoted and closed, checking off
#35738 demoted, checking off

[mvtglobally]

Regression is at 25% left

Quite a few PRs still pending validation and team is still working on issues exporting.

We will provide additional update tomorrow morning

[kbecciv]

Regression is completed!

#34483 is failing #35772, repro in prod, checking off
#34495 is failing #34377 on mWeb, repro in prod, checking off
#35028 is failing #32400

Deploy Blockers:
#35687
#35698
#35701
#35720
#35729
#35730
#35732
#35739
#35745
#35747
#35748
#35749
#35750
#35752
#35753
#35754
#35755
#35757
#35758
#35759
#35761
#35763
#35764
#35765
#35766
#35767
#35771
#35776
#35777
#35782
#35783
#35785
#35787

[Julesssss]

Checked off #35747 as a blocker -- can't reproduce.

[Julesssss]

Checking off #35803 as a blocker, it is minor compared to the rest of today's blockers, we'll handle it as a typical issue in the meantime.

[mountiny]

Demoting, since they are not real blockers:

• [$500] [HOLD for payment 2024-02-14] mweb - Compose - Tapping emoji picker, keypad pops up on emoji box page #35720
• Status - Inconsistent behavior when closing status RHP #35729
• IOU - App resumes in IOU flow when killing app in confirmation page and relaunching app #35730
• [$500] Web - Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page #35732
• [$250] Tooltip - Search tooltip overlaps workspace name and chats #35739

[mountiny]

Demoting:

• Login - Onboarding modal not displayed for new account creation #35748
• [$250] Profile - No spacing between zoom/rotate toolbar & save button in edit photo page #35749
• Chat - When clicking "Go back to home page" user redirected to Workspaces #35750
• [$500] [HOLD for payment 2024-02-20] LHN - User navigated on Workspaces listing page when tapped on the settings tab in bottom #35752
• [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate away from Profile page using the back button #35753
• [HOLD Simplified collect] [$500] Workspace - Right hand page reloads when clicking Connect bank account #35754
• [HOLD for payment 2024-02-20] [$500] LHN - User navigated on the workspace overview page when created workspace #35755

[mountiny]

demoting:

• [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate on the account settings page #35758
• [HOLD for payment 2024-02-20] [$500] LHN - Workspace announce chat opened when selected workspace on "Choose workspace" page #35759
• [HOLD for payment 2024-02-22] [$250] Workspace - Workspace highlighted member blinks when check/uncheck mark #35761
• [Awaiting Payment March 20th] [$500] Report - The conversation scrolls to the beginning when you open the settings menu #35763
• [$500] Workspace-Some workspaces are shown in bold and some not #35766
• [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page #35764
• [HOLD for payment 2024-02-20] [$250] Profile - Error message when loading User / WS avatar has incorrect dimensions and position #35777
• WS Members - 'Back' leads to invite members page instead of Settings after delete added user #35776
• [$500] Workspace - The default room opening after creating a workspace is #announce #35771
• [$500] IOU-In expense report page, title saved is not shown. #35767

[mountiny]

Demoting:

• Workspace - Workspace name is not displayed under cards, Invoices title. #35783
• [HOLD for payment 2024-03-20] [$500] Workspace - Title with /Chats and /Settings is not aligned properly with minimum font size #35785
• [$500] Workspace - Unable to open settings on a policy disabled account #35802
• Text in the composer is very small when device font size is minimum #35787

[mountiny]

demoted:

• iOS - URLs are hyperlinked instead of hyperlink text when edit message #35831
• [HOLD for payment 2024-02-26] [$500] Expense - "Recent" and "All" appear in report field selection list when there is no result #35832

[mountiny]

@marcaaron 3 real blockers left:

• [HOLD for payment 2024-02-14] [$500] mWeb - Magic link - "Sign in here" leads to Abracadabra page. #35782 - no proposal to fix
• [HOLD for payment 2024-02-14] [$500] Chat - App crashes when tapping device back button to return from thread #35765 - SWM working on a fix
• [HOLD for payment 2024-02-14] [$500] Login - Blank screen and infinite spinner when logging in using magic link #35745 contributor has PR up

[marcaaron]

Checking off #35745 as we CP'd a fix to staging.

[marcaaron]

Checking off #35843 as we determined it is already broken on production and the feature is behind a BETA

[thienlnam]

Checking off #35765 as we just CPed a fix to staging

[marcaaron]

We also CP'd a fix for 35850 so that's it for the blockers.

[marcaaron]

This looks high for android - but there is no new data so I am guessing the chart is broken somehow...

[marcaaron]