-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Workspace-Some workspaces are shown in bold and some not #35766
Comments
Job added to Upwork: https://www.upwork.com/jobs/~015db9082b5dbefc79 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
Triggered auto assignment to @alexpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @marcaaron ( |
We think that this bug might be related to #vip-vsb |
This comment was marked as off-topic.
This comment was marked as off-topic.
@ZhenjaHorbach then the actual bug is that some workspace names are not getting the bold font even after having a green or red dot, meanwhile some have bold text even without a dot. |
📣 @puneet2715! 📣
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Some workspaces are shown in bold and some not. What is the root cause of that problem?There might be a delay from onyx when new data is returned for a policy in App/src/pages/WorkspaceSwitcherPage.tsx Line 139 in 3ab4e6e
What changes do you think we should make in order to solve the problem?We could pass a false type to the hasBoldStyle or remove it altogether since the unread have their own green/red dots. What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issueSome workspaces names are not shown in bold text when they are supposed to due to either having red / green brick indicators. What is the root cause of that problem?Lines 3569 to 3578 in 3ab4e6e
Both If what we want here as expected result is to keep the workspace name in bold style when there's no unread reports, but we have red / green brick indicators present then the problem is we're missing an additional condition where we set the What changes do you think we should make in order to solve the problem?Within the
this way if within any of that workspace's reports there's any kind of indicator present -> the workspace name text will have the bold style until the indicator is resolved by the user within the report that is causing it. VideosiOS: Native
|
This is not a blocker, I actually think this is expected behaviour |
This is a dupe of existing issue with better issue body/ repro steps here #35682 |
Right, if the workspace in question has chats with unread messages, the row should be bold. We don't add a GBR for unread messages. That said, I think there's a bug with the bold rows, as logged here: #35682 Perhaps this issue is just a dupe. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
Pre-condition: open account with many workspaces created
Expected Result:
All workspaces should be displayed in same manner.
Actual Result:
Some workspaces are shown in bold and some not.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6366196_1706985592680.az_recorder_20240203_015705.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: