[$500] Workspace - Member list blinks briefly after inviting member to the workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Settings from the bottom
3. Select any workspace
4. Go to Members
5. Invite a member

Expected Result:

The member list will not blink

Actual Result:

The member list blinks briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365145_1706897084155.20240203_001835.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b4737b731439c29
• Upwork Job ID: 1757494678564794368
• Last Price Increase: 2024-02-13

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave 5.
CC @dylanexpensify

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The member list page blinks after adding a new member.

What is the root cause of that problem?

After adding a new member, we will navigate to the workspace members.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 107 in 3ab4e6e

Navigation.navigate(ROUTES.WORKSPACE_MEMBERS.getRoute(props.route.params.policyID));

But we have a logic here to change the navigation type to PUSH if the destination is a central pane navigator (which is true for members page) and the current central pane is not a report screen, so we always push the members page to the stack, thus the page "blinks".

App/src/libs/Navigation/linkTo.ts

Lines 163 to 179 in 3ab4e6e

	action.payload.name === NAVIGATORS.CENTRAL_PANE_NAVIGATOR &&
	topmostCentralPaneRoute &&
	(topmostCentralPaneRoute.name !== SCREENS.REPORT || getTopmostReportId(rootState) !== getTopmostReportId(stateFromPath))
	) {
	// We need to push a tab if the tab doesn't match the central pane route that we are going to push.
	const topmostBottomTabRoute = getTopmostBottomTabRoute(rootState);
	const matchingBottomTabRoute = getMatchingBottomTabRouteForState(stateFromPath, policyID);
	const isNewPolicyID =
	(topmostBottomTabRoute?.params as Record<string, string | undefined>)?.policyID !== (matchingBottomTabRoute?.params as Record<string, string | undefined>)?.policyID;
	if (topmostBottomTabRoute && (topmostBottomTabRoute.name !== matchingBottomTabRoute.name || isNewPolicyID)) {
	root.dispatch({
	type: CONST.NAVIGATION.ACTION_TYPE.PUSH,
	payload: matchingBottomTabRoute,
	});
	}
	action.type = CONST.NAVIGATION.ACTION_TYPE.PUSH;

What changes do you think we should make in order to solve the problem?

We should check whether the route destination is the same as the current central pane route instead of check whether it's a report screen or not. If it's the same, then don't push it.

topmostCentralPaneRoute.name !== action.payload.params.screen

[DylanDylann]

@lanitochka17 Looks like you want to ping @dylanexpensify instead of me

[lanitochka17]

@DylanDylann I'm sorry, you're right

[melvin-bot]

@robertjchen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[robertjchen]

@dylanexpensify Is there anything special we have to do for issues relating to the wave? #35692 (comment)

[dylanexpensify]

looking!

[melvin-bot]

@robertjchen, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[dylanexpensify]

I think it'll be wave6, and low priority but we can open it up

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019b4737b731439c29

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[robertjchen]

🙏

[mollfpr]

I can't reproduce it in the latest main.

Screen.Recording.2024-02-17.at.02.44.07.mp4

[robertjchen]

Thanks for the test @mollfpr , I think we may be all set here for now 👀