Deploy Checklist: New Expensify 2023-03-28

[OSBotify]

Release Version: 1.2.91-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Emoji search on mobile #14652
• Fix/15131: Special html characters like &nbsp are not escaped in name and can bug out the UI #15340
• Removing shouldKeyReportActionsByID #15583
• Add CSP to help.expensify.com #15607
• Fixed correct original props callback on cloneElement #15990
• [Web Proxy] Use staging server for Web, Desktop when the "Use staging server" toggle is ON. #16432
• fix details page crash without route params #16438
• Fix Line breaks are removed after special copy/paste scenario #16464
• [StatePicker] USA to non USA address should not reset state field value #16466
• Increase timeout for npm ci action #16472
• change chat preview subtitle for DM and room chat #16483
• Fix Attachment download links for non-previewable items #16492
• [No QA] Display policy changes logs in NewDot #16500
• [No QA] Update xcode version #16540
• Fix pdf attachment still shows a password form when switch to another pdf attachment #16550
• [Accessibility Labels] Localise accessibility labels and update texts accordingly. #16553
• Translate "reacted with" in tooltip #16555
• Ensure to show the archived report footer for admins and announce rooms #16556
• Revert "Make optimistic reportActions appear last" #16559
• Set tooltip text centered in reaction emojis #16578
• [No QA] Fix lock file #16586
• Add Placeholder text and No results found message on Pronouns Search Page #16602
• Get PlaidData values #16607
• Revert "Emoji search on mobile" #16659

Deploy Blockers:

• [HOLD for payment 2023-04-07] [$1000] DEV: Preview of the image is showing broken and does not display image #16636
• [HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left #16639
• [HOLD for payment 2023-04-07] App Crashing when sending attachments #16641
• [$1000] [HOLD for payment 2023-04-07] mWeb - Chat - If you edit a message using emoji, emoji picker and keyboard opens. #16653

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.91-0 🚀

[mvtglobally]

PR #15340 failing #16507 #15920
PR #16492 failing #16641
PR #16550 failing #16636

[luacmartins]

@mvtglobally we can retest all issues below once the staging CP is completed:

• [HOLD for payment 2023-04-07] [$1000] DEV: Preview of the image is showing broken and does not display image #16636
• [HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left #16639
• [HOLD for payment 2023-04-07] App Crashing when sending attachments #16641
• [$1000] [HOLD for payment 2023-04-07] mWeb - Chat - If you edit a message using emoji, emoji picker and keyboard opens. #16653
• Fix Attachment download links for non-previewable items #16492
• Fix pdf attachment still shows a password form when switch to another pdf attachment #16550

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.91-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.91-1 has been deployed to staging 🎉

[luacmartins]

@mvtglobally when do you expect to complete regression? I see that we are really close.

[mvtglobally]

@luacmartins Main regression is completed.

We are retesting issues and will validate CPs in a few

[mvtglobally]

Regression summary

PR #15340 failing #16507 #15920. Are we ok to check it off?
PR #16492 & #16432 failing #16641 - RETESTING
PR #16464 failing #16668. repro in PROD checking off
PR #16550 failing #16636 - RETESTING

[luacmartins]

@mvtglobally thank you! let me know when you are done retesting those issues

[luacmartins]

Checking off #15340. We just merged another PR today #16055

[mvtglobally]

Checking off #16659.
Will log a new issue for #12512 (comment) (#16550 seem to be unrelated)

[luacmartins]

I tested #16492. It's a pass. Checking it off.

[luacmartins]

I tested #16432, but it seems to fail. I left a comment here. Gonna check it off since it doesn't break any functionality.

[mvtglobally]

#16432 (We didnt see any issue) & Checking off
#16550

[luacmartins]

@mvtglobally thanks for the update!

[luacmartins]

I noticed what seems to be several new non-fatal exceptions in Firebase. I won't block the deploy on it since it's a non-fatal exception, but I think that we should investigate it. I created an issue for it here

[luacmartins]