[$2000] Web -Chat - Line breaks are not displayed correctly after special copy/paste scenario

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #16464

Action Performed:

There will be 2 test cases:

Test case 1 (Test issue in previous PR) - Use the following text for the test (it has 4 newlines + has web link):
I'm around if you are and wanna hop on a call https://meet.google.com/yjx-maas-pku

Nothing specific in mind
Test case 2 (Test the current issue) - Use the following text for the test (it has 4 newlines + no web link):
I hope you have a good day

Cheers
Follow the steps for both scenario or you can use PR link above

1. Copy that text in Test case 1
2. Paste it normally into the chat composer using ctrl+v
3. Verify that it still contains the 4 newlines
4. Paste it without formatting into the chat composer user ctrl+shift+v
5. Verify that it still contains the 4 newlines and no more
6. Send the message
7. Copy the previous message by right-clicking the message and select copy it to clipboard
8. Repeat steps 2-5
9. Copy the message by clicking the copy to clipboard in the hover menu
10. Repeat steps 2-5
11. Copy the message by highlighting all the text of the comment, right-click the message > select copy to clipboard
12. Repeat steps 2-5
13. Copy text inside the composer input that contains newlines by using ctrl+c
14. Repeat steps 2-5
15. Copy text inside the composer input that contains newlines by using ctrl+x
16. Repeat steps 2-5
17. Repeat steps 1->16 for Test case 2

Expected Result:

1. It has 4 newlines + has web link
2. It has 4 newlines + no web link

Actual Result:

Scenario 1:
Step 5. 3 lines instead of 4 for both
Step 8. Paste it without formatting into the chat composer user ctrl+shift+v - 7 lines instead 4
Step 11. two ways is failed - 7 lines instead of 4
Step 13. two ways is failed - 7 lines instead of 4
Scenario 2:
Step 5. 3 lines instead of 4 for both
Step 8. Paste it without formatting into the chat composer user ctrl+shift+v - 7 lines instead 4

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows/ Chrome
• MacOS / Desktop

Version Number: 1.2.91.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

16464.Web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013db20b7edebe8630
• Upwork Job ID: 1651166295134699520
• Last Price Increase: 2023-05-04

[MelvinBot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

hi @kbecciv I assume based on the other PR this is specific to MacOS / Chrome / Safari ?

[kevinksullivan]

Also, are you saying I should test both test case 1 AND 2? Or, because that other issue exists, I'll just do test case 2?

[kbecciv]

Hey @kevinksullivan The tester was QAring on Windows/Chrome, updated the environment.
Both scenario did not work correctly, to test both test case 1 AND 2 will be better.

[kevinksullivan]

Ok, thanks @kbecciv . Next question here. What exactly should I do for these test cases? The steps says:

Test case 1 (Test issue in previous PR) - Use the following text for the test (it has 4 newlines + has web link):
I'm around if you are and wanna hop on a call https://meet.google.com/yjx-maas-pku

Nothing specific in mind
Test case 2 (Test the current issue) - Use the following text for the test (it has 4 newlines + no web link):
I hope you have a good day

Cheers

You're saying in the first test I should take this text and go test the other PR?

I'm around if you are and wanna hop on a call https://meet.google.com/yjx-maas-pku

Nothing specific in mind

Then, for test 2, you're saying I copy/paste this?

I hope you have a good day

Cheers

I'm a bit confused since you say these have 4 "new lines", but I don't understand how you're getting that number?

[MelvinBot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kevinksullivan]

@kbecciv feel free to assign me back once you've clarified. Just want to make sure I understand how this is supposed to work, since there are a lot of steps here!

[kbecciv]

Hey @kevinksullivan! I will re-test the issue shortly and will tag you when it's ready for your review. Thanks

[kevinksullivan]

Sounds good!

[MelvinBot]

@kbecciv Eep! 4 days overdue now. Issues have feelings too...

[kbecciv]

@kevinksullivan I put a wrong PR# under the issue ( it should be #16464), I hope it will be easier to reproduce it.
For the Test case 1:
For the first 5 steps:

1. Copy that text in Test case 1
2. Paste it normally into the chat composer using ctrl+v
3. Verify that it still contains the 4 newlines
4. Paste it without formatting into the chat composer user ctrl+shift+v
5. Verify that it still contains the 4 newlines and no more
   I got 3 newlines instead of 4.

Recording.2468.mp4

[MelvinBot]

@kbecciv this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kevinksullivan]

@sakluger I am going OOO for the week so I am unassigning myself as this one is fresh. It still needs to be reproduced / exported. Thank you!

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[sakluger]

We still haven't reproduce this one, I'm going to look into it tomorrow to reproduce and will label external if it's reproduceable.

[sakluger]

Test 1, 2, 3 #16668

Test 4,5,6

[sakluger]

Test 1,2,3

Test 4,5,6

[sakluger]

@kbecciv, I finally had a chance to test this. For my two test messages above, I copied and pasted with command+v and command+shift+v.

For command+v, there was no newline included for either:

When I pasted without formatting (command+shift+v), it included the newlines:

This doesn't happen when I copy from the Github composer or from the NewDot chat, only when I copy from a Github comment. Doesn't quite sounds like the same exact issue you said it was, but it's still an issue and reproduceable.

[MelvinBot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[eVoloshchak]

Not overdue, this is awaiting proposals

[grgia]

Awaiting proposals

[sakluger]

It's been a week with no proposals, let's increase the price.

[MelvinBot]

Upwork job price has been updated to $2000

[sakluger]

I'm actually going to close this one out. I think there's a good chance that there is something specific to the GH formatting that causes the NewLine to not appear when pasting with formatting, and so there's a good chance this is expected behavior.