Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left #16639

Closed
2 of 6 tasks
kavimuru opened this issue Mar 28, 2023 · 13 comments
Closed
2 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
    3.Open any chat
  3. Click on the Trash icon to delete the message

Expected Result:

The "Delete Comment" tab should be in the center

Actual Result:

The Delete Comment tab has been moved to the left.
Deleting Ws the same issue and Ctrl+I

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.91-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5996210_delete_WS_28 03

Bug5996210_Gravar__2169.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 28, 2023
@MelvinBot
Copy link

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Auto-assign attempt failed, all eligible assignees are OOO.

@varshamb
Copy link
Contributor

I have reported this bug on slack.

https://expensify.slack.com/archives/C049HHMV9SM/p1680023847655009

@situchan
Copy link
Contributor

This is duplicated with #16636 since they have the same root cause

@strepanier03
Copy link
Contributor

Putting this one on HOLD until the linked GH is resolved. Then I'll test and make sure.

@strepanier03 strepanier03 changed the title The "Delete Comment" context tab has been moved to the left [HOLD] The "Delete Comment" context tab has been moved to the left Mar 29, 2023
@strepanier03 strepanier03 added Weekly KSv2 and removed Hourly KSv2 labels Mar 29, 2023
@luacmartins
Copy link
Contributor

I can confirm that reverting #14652 resolves the issue.

@luacmartins
Copy link
Contributor

We reverted the offending PR. This should be fixed once the staging CP is finished.

@luacmartins luacmartins self-assigned this Mar 29, 2023
@luacmartins luacmartins added Hourly KSv2 and removed Weekly KSv2 labels Mar 29, 2023
@stitesExpensify stitesExpensify self-assigned this Mar 29, 2023
@luacmartins
Copy link
Contributor

We shipped the fix and this is solved. Closing.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 30, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Mar 31, 2023
@melvin-bot melvin-bot bot changed the title [HOLD] The "Delete Comment" context tab has been moved to the left [HOLD for payment 2023-04-07] [HOLD] The "Delete Comment" context tab has been moved to the left Mar 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 31, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@MelvinBot
Copy link

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@luacmartins / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
  • [@luacmartins / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@luacmartins / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@strepanier03] Determine if we should create a regression test for this bug.
  • [@luacmartins / @stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants