You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes the current method of creating ignore rules complete break on windows (where filesystemiterator will give you back backslashes to compare against) and makes ignore directories a pain because you need both a singular (ignore /vendor) and plural (ignore vendor/*) to work right
I have a pretty horrible hacked up fixed for this at
it's not entirely ideal (I should have pulled them out into a base helper method that each calls) and it still needs file level support added but it works to do ignores properly
But without some sort of a fix ignores are completely non-usable on windows for these two tools
The text was updated successfully, but these errors were encountered:
zdenekdrahos
changed the title
ignore patterns and pdepends/phpmd
ignore patterns and pdepends/phpmd and Windows
Jun 20, 2017
Pdepends and phpmd have a really painful method of doing ignores
they use the same filter class for their file and then PIPE IT THROUGH REGEX (oh, ick)
https://github.com/pdepend/pdepend/blob/master/src/main/php/PDepend/Input/ExcludePathFilter.php
This makes the current method of creating ignore rules complete break on windows (where filesystemiterator will give you back backslashes to compare against) and makes ignore directories a pain because you need both a singular (ignore /vendor) and plural (ignore vendor/*) to work right
I have a pretty horrible hacked up fixed for this at
https://github.com/auroraeosrose/phpqa/blob/powershell_works/src/IgnoredPaths.php#L28
and
https://github.com/auroraeosrose/phpqa/blob/powershell_works/src/IgnoredPaths.php#L54
it's not entirely ideal (I should have pulled them out into a base helper method that each calls) and it still needs file level support added but it works to do ignores properly
But without some sort of a fix ignores are completely non-usable on windows for these two tools
The text was updated successfully, but these errors were encountered: