Fix binary path, process timeout, ignoring directories on Windows #81

zdenekdrahos · 2017-06-25T06:56:05Z

Can't have any spaces in any tool paths #76 Fix escaping binary path
Symfony Process timeout #77 Don't use default 60s timeout is non-parallel execution
ignore patterns and pdepends/phpmd and Windows #75 Fix ignoring phpmd/pdepend directories on Windows

--execution parallel - null timeout in parallelExec https://github.com/consolidation/Robo/blob/0.7.2/src/Task/Base/ParallelExec.php#L37 --execute no-parallel - 60s timeout was used because process was not initialized like in ParallelExec https://github.com/symfony/process/blob/master/Process.php#L148

zdenekdrahos · 2017-07-01T07:11:59Z

filter	note
`--ignore=/ignored/`	ignores everything in directory `ignored`, it can be on on root level, but also in subdirectory
`--ignore=ignored`	ignores directories, but also files containing the word, e.g. `IgnoredPaths`
`--ignore=vendor/,ignored/`	ignores directories, `IgnoredPaths` is analyzed, directory `sub-ignored` is analyzed

zdenekdrahos · 2017-07-01T07:16:32Z

@auroraeosrose are your issues fixed with this PR?

composer update edgedesign/phpqa:dev-windows-compatibility

Especially ignoring phpmd/pdepend directories? If directories aren't ignored, could you please send me example of working filter. Thanks.

zdenekdrahos · 2017-07-10T07:07:06Z

Merged after comparing results with patched code from #75

zdenekdrahos added 2 commits June 25, 2017 08:24

Escape binary path (it can contain spaces...) - closes #76

67d11a5

zdenekdrahos changed the title ~~Windows compatibility~~ Fix binary path, process timeout, ignoring directories on Windows Jun 25, 2017

Fix ignoring phpmd/pdepend directories on Windows - closes #75

5239b54

zdenekdrahos force-pushed the windows-compatibility branch 2 times, most recently from 3515bc1 to 5239b54 Compare July 3, 2017 13:13

zdenekdrahos merged commit c31a549 into master Jul 10, 2017

zdenekdrahos deleted the windows-compatibility branch July 10, 2017 07:04

zdenekdrahos mentioned this pull request Jun 27, 2018

Fix ignoring subdirectories on Windows #143

Merged

Provide feedback