Fix ignoring phpmd/pdepend directories on Windows - closes #75

EdgedesignCZ · Jul 1, 2017 · f1c9983 · f1c9983
1 parent 5858f8d
commit f1c9983
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 4 deletions.
diff --git a/src/IgnoredPaths.php b/src/IgnoredPaths.php
@@ -7,12 +7,19 @@ class IgnoredPaths
     private $ignoreDirs;
     private $ignoreFiles;
     private $ignoreBoth;
+    private $isWindows;
 
     public function __construct($ignoredDirs, $ignoredFiles)
     {
         $this->ignoreDirs = $this->csvToArray($ignoredDirs);
         $this->ignoreFiles = $this->csvToArray($ignoredFiles);
         $this->ignoreBoth = array_merge($this->ignoreDirs, $this->ignoreFiles);
+        $this->setOS(PHP_OS);
+    }
+
+    public function setOS($os)
+    {
+        $this->isWindows = strtoupper(substr($os, 0, 3)) == 'WIN';
     }
 
     private function csvToArray($csv)
@@ -27,14 +34,25 @@ public function phpcs()
 
     public function pdepend()
     {
+        if ($this->isWindows) {
+            return $this->pdependFilter('ignore');
+        }
         return $this->ignore(' --ignore=/', '/,/', '/', ',/');
     }
 
     public function phpmd()
     {
+        if ($this->isWindows) {
+            return $this->pdependFilter('exclude');
+        }
         return $this->ignore(" --exclude /", '/,/', '/', ',/');
     }
 
+    private function pdependFilter($option)
+    {
+        return $this->ignore(" --{$option}=", '\*,', '\*', ',');
+    }
+
     public function phpmetrics()
     {
         return $this->ignore(' --excluded-dirs="', '|', '"');

diff --git a/tests/IgnoredPathsTest.php b/tests/IgnoredPathsTest.php
@@ -4,9 +4,12 @@
 
 class IgnoredPathsTest extends \PHPUnit_Framework_TestCase
 {
+    private $operatingSystem = 'Linux';
+
     private function ignore($tool, $dirs, $files)
     {
         $paths = new IgnoredPaths($dirs, $files);
+        $paths->setOS($this->operatingSystem);
         return $paths->$tool();
     }
 
@@ -17,11 +20,17 @@ public function testNoOptionWhenNothingIsIgnored($tool)
     }
 
     /** @dataProvider provideTools */
-    public function testShouldIgnoreDirectories($tool, $expectedOptions)
+    public function testIgnoreDirectoriesAndFiles($tool, $expectedOptions, $os = null)
     {
-        assertThat($this->ignore($tool, 'bin,vendor', 'autoload.php,RoboFile.php'), is($expectedOptions['both']));
-        assertThat($this->ignore($tool, 'bin,vendor', ''), is($expectedOptions['dirs']));
-        assertThat($this->ignore($tool, '', 'autoload.php,RoboFile.php'), is($expectedOptions['files']));
+        $this->operatingSystem = $os ?: $this->operatingSystem;
+        $this->assertEquals(
+            $expectedOptions,
+            [
+                'both' => $this->ignore($tool, 'bin,vendor', 'autoload.php,RoboFile.php'),
+                'dirs' => $this->ignore($tool, 'bin,vendor', ''),
+                'files' => $this->ignore($tool, '', 'autoload.php,RoboFile.php'),
+            ]
+        );
     }
 
     public function provideTools()
@@ -51,6 +60,24 @@ public function provideTools()
                     'files' => ' --exclude /autoload.php,/RoboFile.php'
                 )
             ),
+            'pdepend + windows' => array(
+                'pdepend',
+                array(
+                    'both' => ' --ignore=bin\*,vendor\*,autoload.php,RoboFile.php',
+                    'dirs' => ' --ignore=bin\*,vendor\*',
+                    'files' => ' --ignore=autoload.php,RoboFile.php'
+                ),
+                'Windows'
+            ),
+            'phpmd + windows' => array(
+                'phpmd',
+                array(
+                    'both' => ' --exclude=bin\*,vendor\*,autoload.php,RoboFile.php',
+                    'dirs' => ' --exclude=bin\*,vendor\*',
+                    'files' => ' --exclude=autoload.php,RoboFile.php'
+                ),
+                'WIN32'
+            ),
             array(
                 'phpmetrics',
                 array(