-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SANITIZE PHASE] UI Changes and Runtime Improvements (Part 2) #434
Conversation
Qodana for .NET268 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
(waifu2x) Handle Vulkan initialization exception (waifu2x) Fix crash when exiting from console (waifu2x) Fix black output checker Fix NullReferenceException while trying to get alt. CDN stream Fix exception while generating local app notification [skip ci] Sync translation Translate en_US.json in id_ID 100% reviewed source file: 'en_US.json' on 'id_ID'. [skip ci] Sync translation Translate en_US.json in fr_FR [Manual Sync] 100% reviewed source file: 'en_US.json' on 'fr_FR'. Check process existence for GameBoost Fix join Discord button crash (GLC) Disable spellcheck on commands input textbox Fix tray icon not disposed on close Also contains failed attempt at fixing multi instance tray icon Add AssemblyName to properties Organize InvokeProp.cs (TrayIcon) Use SecondWindow mode on Preview Update NuGet(s) Markdig - Add support for GitHub markdown alert xoofx/markdig#774 - WASDK seems to only documentation changes and some dependencies update... microsoft/WindowsAppSDK@v1.5.0...v1.5.1 Remove unused arm64 lib after build Bump version Remove space on AssemblyName Move close method to use CloseApp() Also do the same for TrayIcon stuff Get the ref pointer to the array explicitly in BSDiff
Fix Genshin repair Switch from reflection based json serialization Set assembly infos (TrayIcon) Fix multi instance disappearing tray icon Now set both console and main window name if >1 instance is found using `- #x` prefix Simplify ChangeTitleDragArea Fix default drag area overlapping the region selector
- Removing BackgroundManagement and replacing it with BackgroundImageUtility - Move BackgroundImageUtility source to a proper folder - Move Color Palette generation related code to its own ColorPaletteUtility class - Adding StillImageLoader to load still image - Adding interface to be used by later implementation of Video Background support
Please do not use merge & squash for syncing a branch....
+ Also adding conditional null to BackgroundMediaUtility.Current
|
Process info log might crash the app if the info is not exist or nulled in the instance of a ghost process
Iterate between all possible instances. If fail, dont increment the count and continue (hopefully) in grace
Markdig.Signed https://github.com/xoofx/markdig/releases/tag/0.37.0 Protobuf.Tools NaN WASDK microsoft/WindowsAppSDK@v1.5.1...main
Co-authored-by: Kemal Setya Adhi <dev.kemalsetyaa@gmail.com> Co-authored-by: Shatyuka <958182453@qq.com>
Important
Do NOT push into this branch unless its a direct fix for change(s) that already happened into it.
If you want to make an improvement, please make a new branch based on this branch or wait until the PR is properly merged.
Important
Run
XamlStyler.bat
once before merge and DO NOT use squash to merge this PR.Warning
Due to heavy changes in window size and image handler, need to inform user to clear image cache.
Description
This second part of UI Changes and Runtime Improvements PR is focused on moving some custom UI element builder using
UIElementExtensions
with builder methods to assign the element's properties (for example: Margin, Padding, Columns and Row forPanel
s like Grid and StackPanel, etc.)Method Usage Example for UIElementExtensions
Case example
Creating a
Grid
with 2x2 panel and addinTextBlock
s inside it and modify its textThis PR also brings a new
BackgroundMediaUtility
to handle the background image/video routine.Wait, I said "video" there? YES, I also added a support for Video Background. This is a long-waited feature that we have struggled to implement but finally, we are managed to implement this feature thanks to the new
BackgroundMediaUtility
and its interface to make the implementation easier and more unified.Video Background Support Overview
2024-04-08.04-22-13.webm
Instant Region Change Overview
Video Showcase
20240331-0431-38.1779307.mp4
Required PR