Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: If Collapse updates while game is running, playtime counter does not restart after update. #446

Closed
Kiki79250CoC opened this issue Mar 28, 2024 · 3 comments · Fixed by #434
Assignees
Labels
Area: Launcher Issue labeled for Launcher update mechanism Bug Something isn't working Fixed Issue has been fixed

Comments

@Kiki79250CoC
Copy link

Affected Version

1.73.8

Bug Behavior

I noticed that Collapse updated itself to the latest version while game was running, and after update, the playtime counter does not start counting again after update completed, it stays on the value it was before the update began.

I noticed that yesterday after the (long) 10-hour session I made to complete HSR 2.1 quest to avoid getting spoiled that the counter stopped counting after only 31 minutes.

Expected Behavior

2 solutions:

  1. Collapse should temporarily pause update check if a game is running
  2. After an update, the counter should start again to count

In both case the counter should not be paused, or can be paused during update and restart immediately after.

Steps to reproduce

  1. Run game
  2. MIRACLE! An update is detected while game is running.
  3. See after update completes, the "Game is running" button is grayed out as it should be, but the playtime counter does not restart.

Related Issues

No response

Screenshot(s)

No response

Additional Information

OS : Windows 11 22H2 (10.0.22621.3296 - March 2024 MCR)

@Kiki79250CoC Kiki79250CoC added the Needs Triaging This issue needs the developer's attention to sort & prioritize. label Mar 28, 2024
bagusnl added a commit that referenced this issue Mar 28, 2024
@bagusnl bagusnl linked a pull request Mar 28, 2024 that will close this issue
1 task
@bagusnl bagusnl self-assigned this Mar 28, 2024
@bagusnl bagusnl added Bug Something isn't working Fixed Issue has been fixed Area: Launcher Issue labeled for Launcher update mechanism and removed Needs Triaging This issue needs the developer's attention to sort & prioritize. labels Mar 28, 2024
@bagusnl
Copy link
Member

bagusnl commented Mar 28, 2024

Fixed in 8113ffc
Fix will be shipped once #434 is merged and pushed to release

Thank you for reporting the issue!
You can keep this thread open as it will close once merge is complete

@bagusnl
Copy link
Member

bagusnl commented Mar 28, 2024

@all-contributors please add @Kiki79250CoC for translation and bug

Copy link
Contributor

@bagusnl

I've put up a pull request to add @Kiki79250CoC! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Launcher Issue labeled for Launcher update mechanism Bug Something isn't working Fixed Issue has been fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants