Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Region Change #449

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Instant Region Change #449

merged 8 commits into from
Apr 1, 2024

Conversation

bagusnl
Copy link
Member

@bagusnl bagusnl commented Mar 30, 2024 •
edited
Loading

  • Instantly change the region when selected game or region is changed.
  • Hide the "Change" button.
  • Enabled by default when "Show Region Warning" is disabled

image

Video Showcase

20240331-0431-38.1779307.mp4

@bagusnl bagusnl requested a review from a team March 30, 2024 23:51
@bagusnl bagusnl added Enhancement New feature or request Area: UI/UX Issue labeled for User Interface/eXperience related issue labels Mar 30, 2024
@bagusnl bagusnl mentioned this pull request Mar 30, 2024
Merged
1 task
bagusnl
bagusnl commented Mar 31, 2024
View reviewed changes
Copy link
Member Author

@bagusnl bagusnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end, requesting review from anyone on @CollapseLauncher/core-maintainers

shatyuka
shatyuka reviewed Mar 31, 2024
View reviewed changes
Copy link
Contributor

@shatyuka shatyuka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to change region if we turn off "instant change region" toggle unless a restart. Maybe we can preserve the old behavior (instant change ON), while showing "instant change OFF" and a restart notice in the settings page.

@bagusnl
PR Review Fixes
dd2901c 
- Cache IsInstantRegionChange
This avoids being unable to change region when the settings changed and user did not restart immediately

- Only show restart warning if settings is actually changed
@bagusnl bagusnl requested a review from shatyuka March 31, 2024 17:24
@bagusnl bagusnl merged commit 9e43bcb into uiext-adaptation Apr 1, 2024
2 checks passed
@bagusnl bagusnl deleted the instant-reg-change branch April 1, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatyuka shatyuka shatyuka approved these changes

Assignees

@bagusnl bagusnl

@neon-nyan neon-nyan

Labels
Area: UI/UX Issue labeled for User Interface/eXperience related issue Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bagusnl @shatyuka @neon-nyan