persistNetworkIdentity cli option
#5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
force-pushed
the
tuyen/peerIdFile
branch
from
36be594
to
5608158
Compare
wemeetagain
reviewed
Feb 20, 2023
| @@ -140,7 +145,7 @@ export async function beaconHandlerInit(args: BeaconArgs & GlobalArgs) { | |||
| } | |||
|
|
|||
| // Create new PeerId everytime by default, unless peerIdFile is provided | |||
| const peerId = await createSecp256k1PeerId(); | |||
| const peerId = args.peerIdFile ? await readPeerId(args.peerIdFile) : await createSecp256k1PeerId(); | |||
| const enr = SignableENR.createV4(createKeypairFromPeerId(peerId)); | |||
There was a problem hiding this comment.
I think we need something like:
// If peerIdFile
// attempt to read enr from disk, beaconDir/enr
// accept enr if enr.peerId == peerId
// else
// create new enr
Otherwise, when using peerIdFile, then restarting, the discv5 network will ignore our enr updates since the enr seqno has been reset.
wemeetagain
approved these changes
Mar 1, 2023
|
🎉 This PR is included in v1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
peerIdFileoption as global optionpeerIdFile, if it does exist it'll throw errorError: ENOENT: no such file or directoryCloses #4992