Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI option to persist peerId and ENR #4992

Closed
wemeetagain opened this issue Jan 9, 2023 · 0 comments · Fixed by #5175
Closed

Add CLI option to persist peerId and ENR #4992

wemeetagain opened this issue Jan 9, 2023 · 0 comments · Fixed by #5175
Assignees
@twoeths
Labels
prio-low This is nice to have. scope-ux Issues for CLI UX or general consumer UX.

Comments

@wemeetagain
Copy link
Member 

    > We should write the ENR on shutdown too, no? only if --peerIdFile is set.

peerId is never re-use with current code. Once that is added yes, the ENR should be persisted on shutdown

Originally posted by @dapplion in #4989 (comment)
@wemeetagain wemeetagain added the prio-low This is nice to have. label Jan 9, 2023
@dapplion dapplion added the scope-ux Issues for CLI UX or general consumer UX. label Jan 10, 2023
@twoeths twoeths self-assigned this Feb 20, 2023
@twoeths twoeths mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoeths twoeths

Labels
prio-low This is nice to have. scope-ux Issues for CLI UX or general consumer UX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

persistNetworkIdentity cli option ChainSafe/lodestar
3 participants
@wemeetagain @twoeths @dapplion