Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low gossipsub score due to p7 #5074

Closed
twoeths opened this issue Jan 30, 2023 · 4 comments
Closed

Low gossipsub score due to p7 #5074

twoeths opened this issue Jan 30, 2023 · 4 comments
Assignees
Labels
prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. scope-networking All issues related to networking, gossip, and libp2p.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jan 30, 2023

Describe the bug

This fix ChainSafe/js-libp2p-gossipsub#385 helps minimize broken promises for a while, however since Jan 25 we catch less promises from duplicate and there are more broken promises

This is monitored from a mainnet node subscribing to all subnets. Update: this happens on all mainnet nodes

Screen Shot 2023-01-30 at 09 22 54

Screen Shot 2023-01-30 at 09 23 29

Screen Shot 2023-01-30 at 09 23 53

Expected behavior

Low broken promises

@twoeths
Copy link
Contributor Author

twoeths commented Jan 30, 2023

On mainnet, the percentage of promise broken ratio is quite high since Jan 25

Screen Shot 2023-01-30 at 10 10 39

@twoeths
Copy link
Contributor Author

twoeths commented Feb 6, 2023

since Jan 25 on mainnet nodes there are more Nimbus peers

Screen Shot 2023-02-06 at 08 42 48

there are a lot of IWANT promise that's never delivered since then

Screen Shot 2023-02-06 at 08 43 43

this PR also confirms Nimbus peer score is low #5094 (comment)

need to work with Nimbus to improve its gossip peer score

@philknows philknows added prio-high Resolve issues as soon as possible. scope-networking All issues related to networking, gossip, and libp2p. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. labels Feb 11, 2023
@twoeths
Copy link
Contributor Author

twoeths commented Feb 21, 2023

Some issues/PRs in progress in order to debug this issue:

@twoeths
Copy link
Contributor Author

twoeths commented Mar 28, 2023

This issue disappeared since Mar 06. Also Nimbus had a fix to not limit responding only first 25 message ids in response to gossip Iwant request

The number of Nimbus peers is also not consistently high as earlier: some have very few Nimbus peers, some have up to 50% Nimbus peers

Screenshot 2023-03-28 at 08 26 46

Closing the issue.

@twoeths twoeths closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

No branches or pull requests

2 participants