add fast subgroup check for is_torsion_free #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmasson
suggested changes
Apr 7, 2022
simonmasson
reviewed
Apr 7, 2022
str4d
requested changes
Apr 7, 2022
added 2 commits
April 7, 2022 19:44
ghost
commented
Apr 8, 2022
ebfull
requested changes
Apr 20, 2022
ebfull
requested changes
Apr 20, 2022
str4d
approved these changes
Apr 22, 2022
Comment on lines
+421
to
+428
| pub const BETA: Fp = Fp::from_raw_unchecked([ | ||
| 0x30f1_361b_798a_64e8, | ||
| 0xf3b8_ddab_7ece_5a2a, | ||
| 0x16a8_ca3a_c615_77f7, | ||
| 0xc26a_2ff8_74fd_029b, | ||
| 0x3636_b766_6070_1c6e, | ||
| 0x051b_a4ab_241b_6160, | ||
| ]); |
There was a problem hiding this comment.
I confirmed that this matches the output of the Sage script.
Co-authored-by: str4d <thestr4d@gmail.com>
Co-authored-by: str4d <thestr4d@gmail.com>
ghost
requested a review
from
ebfull
approved these changes
May 4, 2022
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #80, this uses Scott's method from https://eprint.iacr.org/2021/1130 as implemented by @simonmasson for arkworks (arkworks-rs/curves#74)