Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply zkcrypto patches to improve the efficiency of the library #87

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

xevisalle
Copy link
Member

This PR applies two patches from the original repository we forked, zkcrypto. The patches are the following ones, which lead to a performance improvement:

@xevisalle xevisalle added area:cryptography anything related to cryptographic primitives, hashing and ZKP type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) labels May 27, 2022
@xevisalle xevisalle self-assigned this May 27, 2022
@xevisalle xevisalle linked an issue May 27, 2022 that may be closed by this pull request
@xevisalle xevisalle marked this pull request as ready for review May 30, 2022 08:07
@xevisalle xevisalle requested review from moCello and ZER0 May 30, 2022 08:08
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would split some comments into multiple lines, but that's a nit

// an element of F_p^6, and a_i = (a_i,0, a_i,1) is an element of F_p^2. The fully
// expanded multiplication is given by (2022-376 §5):
//
// c_0,0 = a_0,0 b_0,0 - a_0,1 b_0,1 + a_1,0 b_2,0 - a_1,1 b_2,1 + a_2,0 b_1,0 - a_2,1 b_1,1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines

@xevisalle xevisalle merged commit 00efc28 into master Jul 22, 2022
@xevisalle xevisalle deleted the apply_patch branch July 22, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cryptography anything related to cryptographic primitives, hashing and ZKP type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply patches from zkcrypto to improve the efficiency
2 participants