Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: message_t could be easier to construct and is missing equal not equal operators #203

Merged
merged 2 commits into from
Apr 14, 2018
Merged

Problem: message_t could be easier to construct and is missing equal not equal operators #203

merged 2 commits into from
Apr 14, 2018

Commits on Apr 14, 2018

  1. Problem: message_t should be easier to construct 

    * Added overload constructor (c++11 only) taking iteratable object.
  It would be easier to use std::string, std::array etc to construct
  a message now. Making it a draft for now in case it is too greedy
  and needs to be more specialize.
* Added equal and not euqal operator to message_t as a recommended
  and expected way of comparing objects in C++.
* deprecated C style equal method as operator== should be used instead
  (point above).
* Added message_t test covering all available message_t's constructors
    @kurdybacha
    kurdybacha committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    6caa5d1 View commit details
    Browse the repository at this point in the history

  2. Problem: extended initializer lists only available in C++11

    @kurdybacha
    kurdybacha committed Apr 14, 2018
    Configuration menu
    Copy the full SHA
    f518a64 View commit details
    Browse the repository at this point in the history