Problem: message_t could be easier to construct and is missing equal not equal operators #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added overload constructor (c++11 only) taking iteratable object. It would be easier to use std::string, std::array etc to construct a message now. Making it a draft for now in case it is too greedy and needs to be more specialize. * Added equal and not euqal operator to message_t as a recommended and expected way of comparing objects in C++. * deprecated C style equal method as operator== should be used instead (point above). * Added message_t test covering all available message_t's constructors
Pull Request Test Coverage Report for Build 24
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be easier to use std::string, std::array etc to construct
a message now. Making it a draft for now in case it is too greedy
and needs to be more specialize.
and expected way of comparing objects in C++.
(point above).
and equal, not equal operators.