Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added flexbox, some styles #532

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added flexbox, some styles #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 59 additions & 30 deletions Fast typing/Typing.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,50 +1,79 @@
body
{
background:radial-gradient(#00faff ,#f981f3 60%);
background:radial-gradient(#1f3300 ,#000000 60%);
border: solid black 40px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to have the consistency please use the hexacode #000 instead of black string

margin: 0;
overflow:hidden;

}
h2 {
animation: type 1.5s steps(17);
h1 {
display: block;
animation: type 1.7s steps(29);
overflow: hidden;
white-space: nowrap;
font-family: monospace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a global style. Hence, move this to the body

border-right: 16px solid black;
width: 19ch;
color:red;
width: 29ch;
color:rgb(109, 0, 0);
background: rgb(180, 177, 177);
margin: 10px, 0, 0, 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin correct syntax is : margin: 10px 0 0 0 (no comma)

padding: 0;
}
marquee {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marquee is deprecated tag: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/marquee

background: black;
color: antiquewhite;
margin: 0;
font-family: fantasy;
}
#container a {
color: rgb(36, 1, 78);
font-size: 24px;
align-self: center;
}

#container {
display: flex;
flex-flow:column nowrap;
align-items:start;
gap: 40px;
width: 80%;
margin-left: 4%;
background:radial-gradient(#00faff ,#f981f3 60%);
border: double rgb(252, 225, 190) 51px;
}

.Can {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the class name should not start with the uppercase to have consistency and have a clear name which reflect what the class is doing

margin-top: 5%;
align-self: center;
padding-bottom: 1vmax;
}

#startButtonId {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting is missing.

Consistency in the units of font-size, margin, and colour is missing. It is prefer to stick to one unit

border-radius: 30%;
border-bottom: 14px ;
border-top: 14px ;
width: 100px;
height: 100px;
-webkit-animation: spin 1.5s linear
infinite;
animation: spin 1.8s linear infinite;
background-color: antiquewhite;
margin-top: 0;
margin-bottom: 10%;
padding: 0;

}

@keyframes type {
0% {
width: 0ch;
}
100% {
width: 19ch;
width: 29ch;
}
}
Can {
text-align:center;
}
#startButtonId {
position:absolute;
left:34%;
top:195px;
border-radius: 30%;
border-bottom: 14px ;
border-top: 14px ;
width: 100px;
height: 100px;
-webkit-animation: spin 1.5s linear
infinite;
animation: spin 1.8s linear infinite;
background-color: black;

}
#buttonText {
color: white;
text-align: center;
font-size: x-large ;
padding: 30x;
}


@-webkit-keyframes spin {
0% {-webkit-transform: rotate(0deg);}
100% { -webkit-transform:
Expand Down
18 changes: 8 additions & 10 deletions Fast typing/Typing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,16 @@
<link rel="stylesheet" href="Typing.css">
</head>
<body>
<h2>Welcome in my code.</h2>
<br /><br /><br />

<marquee>You can follow me on<br/>👇👇👇👇👇👇👇👇</marquee>

<div id="container">
<h1>Welcome 2 my open source code.</h1>
<!-- Hi there! What's your name? Should we add it in this h1 above? -->
<marquee>You can follow me on<br/>👇👇👇👇👇👇👇👇</marquee>
<a href="https://www.youtube.com/channel/UCf_Rde_c0kf093lkPsk1P1w">My youtube channel</a>
<div class="Can">
<div id="startButtonId">
Copy link
Contributor

@Neha Neha Aug 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id name should not have ID in it. Rename it to "startButton" Instead of adding an extra div on a tag. Style a tag to look like a button

<div id="buttonText">
<a href=https://www.sololearn.com/Profile/8855482/?ref=app><img alt="SoloLearn" src="https://www.sololearn.com/Uploads/icons/sololearn.png" width=100px height=100px /></a>
</div> </div>
</div>
<br /><br /><br /><br /><br /><br /><br /><br />
<a href="https://www.youtube.com/channel/UCf_Rde_c0kf093lkPsk1P1w">My youtube channel</a>
</div>
</div>
</div>
</body>
</html>