added flexbox, some styles #532
Conversation
|
🙏 Thanks for your pull request @leerobertdyer, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
| @@ -1,50 +1,79 @@ | |||
| body | |||
| { | |||
| background:radial-gradient(#00faff ,#f981f3 60%); | |||
| background:radial-gradient(#1f3300 ,#000000 60%); | |||
| border: solid black 40px; | |||
There was a problem hiding this comment.
to have the consistency please use the hexacode #000 instead of black string
| animation: type 1.5s steps(17); | ||
| h1 { | ||
| display: block; | ||
| animation: type 1.7s steps(29); | ||
| overflow: hidden; | ||
| white-space: nowrap; | ||
| font-family: monospace; |
There was a problem hiding this comment.
This should be a global style. Hence, move this to the body
| width: 29ch; | ||
| color:rgb(109, 0, 0); | ||
| background: rgb(180, 177, 177); | ||
| margin: 10px, 0, 0, 0; |
There was a problem hiding this comment.
margin correct syntax is : margin: 10px 0 0 0 (no comma)
| margin: 10px, 0, 0, 0; | ||
| padding: 0; | ||
| } | ||
| marquee { |
There was a problem hiding this comment.
Marquee is deprecated tag: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/marquee
| border: double rgb(252, 225, 190) 51px; | ||
| } | ||
|
|
||
| .Can { |
There was a problem hiding this comment.
the class name should not start with the uppercase to have consistency and have a clear name which reflect what the class is doing
| padding-bottom: 1vmax; | ||
| } | ||
|
|
||
| #startButtonId { |
There was a problem hiding this comment.
Formatting is missing.
Consistency in the units of font-size, margin, and colour is missing. It is prefer to stick to one unit
| <h1>Welcome 2 my open source code.</h1> | ||
| <!-- Hi there! What's your name? Should we add it in this h1 above? --> | ||
| <marquee>You can follow me on<br/>👇👇👇👇👇👇👇👇</marquee> | ||
| <a href="https://www.youtube.com/channel/UCf_Rde_c0kf093lkPsk1P1w">My youtube channel</a> | ||
| <div class="Can"> | ||
| <div id="startButtonId"> |
There was a problem hiding this comment.
the id name should not have ID in it. Rename it to "startButton" Instead of adding an extra div on a tag. Style a tag to look like a button
Hello, just adding some style to this html page. @Neha I'm just testing things, let me know if this isn't working and thank you!