Misc fixes #2732

schustmi · 2024-05-28T11:43:24Z

Describe changes

This PR adds the following features/fixes:

New orchestrator_pod_settings for the KubernetesOrchestrator: These allow users to specify pod settings for the orchestrator pod which is responsible for launching the other pods that execute the pipeline steps.
Allow specifying pod settings via the CLI: In some other stack components, a custom pydantic validator was used to convert json strings coming from the CLI to the correct type needed in the configuration. This was missing for the pod settings on all of our orchestrators that support them. This PR adds a generic method on the StackComponentConfig class that solves this issue. We will need to port this to pydantic v2 (FYI @bcdurak)
Fix the links for pipeline runs and models when connected to a cloud tenant: Changes in the last release led to an issue that currently we log links to the legacy dashboard instead of the cloud dashboard for pipeline runs and models.

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2024-05-28T11:43:29Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-05-28T11:49:11Z

Quickstart template updates in examples/quickstart have been pushed.

AlexejPenner

The only thing missing are docs on the KubernetesOrchestrator to describe the difference between the two pod settings - feel free to do that separately from this PR in our docs overhaul branch

schustmi · 2024-06-03T08:27:56Z

@AlexejPenner I added it to the docs on your branch

AlexejPenner · 2024-06-03T09:04:24Z

LGTM then

bcdurak

LGTM!

bcdurak · 2024-06-03T12:01:35Z

src/zenml/stack/stack_component.py

+            ValueError: If the value is an invalid JSON string.
+        """
+        if isinstance(value, str):
+            if get_origin(field.outer_type_) in [


Just a small reminder, aside from the get_origin, there are a few more things that need to change here when we switch to pydantic v2 such as the type_, outer_type_, parse_raw and dict()

bcdurak · 2024-06-03T12:02:16Z

src/zenml/utils/dashboard_utils.py

@@ -42,7 +42,7 @@ def is_cloud_server(server_info: ServerModel) -> bool:
    """
    return (
        "organization_id" in server_info.metadata
-        and "cloud.zenml.io" in server_info.server_url
+        and "cloud.zenml.io" in server_info.dashboard_url


Just out of curiosity, why did we have to change this?

This PR (#2722) essentially switched the URLs of these fields, which means in the latest release is_cloud_server is always False even for cloud tenants.

schustmi added 3 commits May 28, 2024 12:53

Fix run/model urls for cloud tenants

c163f64

Add orchestrator pod settings

27e3167

Add generic way of handling json values in stack component configs

e2802be

schustmi requested review from bcdurak and AlexejPenner May 28, 2024 11:43

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels May 28, 2024

schustmi and others added 3 commits May 28, 2024 13:44

Fix docstring

3251780

Add safety check

c3e800e

Auto-update of Starter template

b27cb2a

AlexejPenner mentioned this pull request May 29, 2024

Don't use pod resources/affinity for kubernetes orchestrator pod #2707

Merged

9 tasks

AlexejPenner approved these changes May 29, 2024

View reviewed changes

schustmi added the run-slow-ci label Jun 3, 2024

bcdurak approved these changes Jun 3, 2024

View reviewed changes

schustmi added 6 commits June 3, 2024 14:58

Merge branch 'develop' into feature/kubernetes-orchestrator-pod-settings

5ffed97

Add test

bf14319

Switch to set

97ece9b

Linting

039b8c8

Convert to root validator

a19f794

Docstring

bf9cc53

schustmi merged commit c1c0222 into develop Jun 3, 2024
70 of 72 checks passed

schustmi deleted the feature/kubernetes-orchestrator-pod-settings branch June 3, 2024 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc fixes #2732

Misc fixes #2732

schustmi commented May 28, 2024

coderabbitai bot commented May 28, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented May 28, 2024

AlexejPenner left a comment

schustmi commented Jun 3, 2024

AlexejPenner commented Jun 3, 2024

bcdurak left a comment

bcdurak Jun 3, 2024

bcdurak Jun 3, 2024

schustmi Jun 3, 2024

Misc fixes #2732

Misc fixes #2732

Conversation

schustmi commented May 28, 2024

Describe changes

Pre-requisites

Types of changes

coderabbitai bot commented May 28, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented May 28, 2024

AlexejPenner left a comment

Choose a reason for hiding this comment

schustmi commented Jun 3, 2024

AlexejPenner commented Jun 3, 2024

bcdurak left a comment

Choose a reason for hiding this comment

bcdurak Jun 3, 2024

Choose a reason for hiding this comment

bcdurak Jun 3, 2024

Choose a reason for hiding this comment

schustmi Jun 3, 2024

Choose a reason for hiding this comment

coderabbitai bot commented May 28, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)