-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a clear separation between server and dashboard API in the server configuration #2722
Conversation
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
LLM Finetuning template updates in |
85c84ff
to
525f5a4
Compare
src/zenml/cli/web_login.py
Outdated
@@ -128,6 +128,7 @@ def web_login(url: str, verify_ssl: Union[str, bool]) -> str: | |||
auth_response.verification_uri_complete | |||
or auth_response.verification_uri | |||
) | |||
breakpoint() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zoink !
201863f
to
7c97d5c
Compare
7c97d5c
to
da9e49c
Compare
Describe changes
There was some confusion and overlap between the
base_url
anddashboard_url
ZenML server configuration values. This PR makes a clear separation between these configurations and includes them both in the server info and using them properly throughout:server_url
replacesbase_url
- this is where the ZenML server itself is running / served.dashboard_url
- this is where the ZenML dashboard is served. Can be different thanserver_url
Both values will always be set for ZenML Cloud tenants. Neither needs to be set for self-hosted servers.
Side-changes
Backwards compatibility
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes