Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use option or environment variable for imgur_upload. #2235

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

jonthegeek
Copy link
Contributor

Closes #2233.

I implemented it like xfun::tinify(), but I'm not sure if it makes sense to involve opts_knit here.

Closes yihui#2233.

I implemented it like xfun::tinify(), but I'm not sure if it makes sense to involve opts_knit here.
@cderv
Copy link
Collaborator

cderv commented Feb 27, 2023

Not sure about the CI error, seems like something is happening with pak. Maybe transient...

Regarding opts_knit, this would still be valid and it is the current way of providing a key. reprex could have leveraged that for example. See in https://github.com/tidyverse/reprex/blob/77ec1f612ea3d94534d6b37336a45f2d2957f3b2/R/reprex_document.R#L73-L77

reprex define the use of imgur and could have offer a way to configure this using reprex options and the key argument.

However, I find it a good idea to get option or/and env var from the knitr function directly.

I let @yihui do the review for his thoughts.

@cderv cderv requested a review from yihui February 27, 2023 17:25
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yihui yihui merged commit 76270f1 into yihui:master Apr 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imgur_upload option?
3 participants