-
-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgur_upload option? #2233
Comments
Yes you can PR. We don't currently test it as part of the package - it is tested in knitr-examples I don't think it needs further test just replacing the default key in the function with Though I don't know if an option or an environment variable is preferred. @yihui do you have a preference ? We should probably follow the pattern of
|
Environment variables are slightly more GHA-friendly, and I imagine that's a case where this would be used, so option > env > default makes sense to me! I'll PR this in a sec... |
Closes yihui#2233. I implemented it like xfun::tinify(), but I'm not sure if it makes sense to involve opts_knit here.
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary. |
Suggestion for improvement:
?knitr::imgur_upload
saysThis would be much more feasible if
imgur_upload()
consulted an environment variable (and/or option) for the key.Right now, when
imgur_upload()
is used insidereprex::reprex()
, there's no way to pass a key.I could PR this if you agree, but I'm not sure about testing nor whether there's already a pattern for this sort of thing in knitr.
The text was updated successfully, but these errors were encountered: