Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.test.ts: Improve readbility, add types to fix TS problems #1482

Merged
merged 8 commits into from
Oct 21, 2023
Merged

fs.test.ts: Improve readbility, add types to fix TS problems #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ca18ab
more readable const names instead of index number ([2] etc)
weedySeaDragon Oct 19, 2023
4481d7d
verify fs method name exists in Base.prototype (fixes type problem)
weedySeaDragon Oct 19, 2023
94bfae1
use Data type from ejs. Must include ejs package explicitly
weedySeaDragon Oct 21, 2023
1639035
use SinonStub type
weedySeaDragon Oct 21, 2023
81ac362
ts-expect-error for spyOn type; comment re: why not use sinonStub for…
weedySeaDragon Oct 21, 2023
cac8ad6
types for op. results, paths; put op results into var so it can be ty…
weedySeaDragon Oct 21, 2023
1b8cb4a
add missing help: to new generator options
weedySeaDragon Oct 21, 2023
2954270
removed unneeded eslint disable
weedySeaDragon Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
},
"devDependencies": {
"@types/debug": "^4.1.9",
"@types/ejs": "^3.1.4",
"@types/inquirer": "^9.0.4",
"@types/minimist": "^1.2.3",
"@types/semver": "^7.5.3",
Expand All @@ -80,6 +81,7 @@
"@yeoman/transform": "^1.2.0",
"c8": "^8.0.1",
"cpy-cli": "^5.0.0",
"ejs": "^3.1.9",
"esmocha": "^1.0.1",
"inquirer": "^9.2.11",
"jsdoc": "^4.0.2",
Expand Down
1 change: 0 additions & 1 deletion src/actions/fs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* eslint max-params: [1, 5] */
import assert from 'node:assert';
import { type CopyOptions, type MemFsEditor } from 'mem-fs-editor';
// eslint-disable-next-line import/no-extraneous-dependencies
import type { Data as TemplateData, Options as TemplateOptions } from 'ejs';
import type { OverloadParameters, OverloadReturnType } from '../types-utils.js';
import type BaseGenerator from '../generator.js';
Expand Down
Loading
Loading