Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.test.ts: Improve readbility, add types to fix TS problems #1482

Merged
merged 8 commits into from
Oct 21, 2023
Merged

fs.test.ts: Improve readbility, add types to fix TS problems #1482

merged 8 commits into from
Oct 21, 2023

Commits on Oct 20, 2023

  1. more readable const names instead of index number ([2] etc)

    @weedySeaDragon
    weedySeaDragon committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8ca18ab View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. verify fs method name exists in Base.prototype (fixes type problem)

    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    4481d7d View commit details
    Browse the repository at this point in the history

  2. use Data type from ejs. Must include ejs package explicitly

    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    94bfae1 View commit details
    Browse the repository at this point in the history

  3. use SinonStub type

    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    1639035 View commit details
    Browse the repository at this point in the history

  4. ts-expect-error for spyOn type; comment re: why not use sinonStub for… 

    … get config ?
    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    81ac362 View commit details
    Browse the repository at this point in the history

  5. types for op. results, paths; put op results into var so it can be ty… 

    …ped as FSOpResult[]
    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    cac8ad6 View commit details
    Browse the repository at this point in the history

  6. add missing help: to new generator options

    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    1b8cb4a View commit details
    Browse the repository at this point in the history

  7. removed unneeded eslint disable

    @weedySeaDragon
    weedySeaDragon committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    2954270 View commit details
    Browse the repository at this point in the history