Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new 'html' button from #1235 #1291

Merged
merged 7 commits into from
Feb 7, 2017
Merged

Adding new 'html' button from #1235 #1291

merged 7 commits into from
Feb 7, 2017

Conversation

nmielnik
Copy link
Member

@nmielnik nmielnik commented Feb 6, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets (Finishing #1235)
License MIT

Description

A new tool button for evaluating inserted html, basically for embedding videos or objects.

Thanks to @vendelin8 for creating the feature!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 94.743% when pulling 9605c62 on integration-1235 into 864c7ac on master.

@nmielnik nmielnik mentioned this pull request Feb 6, 2017
@nmielnik
Copy link
Member Author

nmielnik commented Feb 6, 2017

Looks like there are some failures in Firefox & IE, most likely because we have custom code for handling insertHTML in those browsers which don't support it or do it inconsistently. Need some more investigation before we can merge this in.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 94.743% when pulling c724d7f on integration-1235 into 864c7ac on master.

@nmielnik nmielnik merged commit 9b511b2 into master Feb 7, 2017
@j0k3r j0k3r deleted the integration-1235 branch February 7, 2017 19:59
@j0k3r
Copy link
Contributor

j0k3r commented Feb 7, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants