Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval html toolbutton #1235

Closed
wants to merge 2 commits into from
Closed

Eval html toolbutton #1235

wants to merge 2 commits into from

Conversation

vendelin8
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
New tests added? yes
Fixed tickets
License MIT

Description

A new tool button for evaluating inserted html, basically for embedding videos or objects.

Please, don't submit /dist files with your PR!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 94.739% when pulling f0dd84e on vendelin8:eval-html-toolbutton into d2c21a7 on yabwe:master.

@nmielnik
Copy link
Member

nmielnik commented Feb 5, 2017

@vendelin8 would you mind just calling this 'html' instead of 'eval'? Inserting raw html is a pretty common concept for text-editors, so I think it would be pretty intuitive what 'html' would mean.

My guess is that developer would have one set of expectations for what 'eval' means (scary javascript) and regular non-coder users would be perplexed as to what 'eval' could mean...

Also, there are 2 other places to mention your new button:

  1. In the README
  2. In the extensions README

This is a nice and simple idea, I like it. Sorry for your PR sitting for such a crazy long time, my attempt at recruiting more collaborators failed before I had to get pulled into a bunch of other projects.

@vendelin8
Copy link
Author

@nmielnik I don't mind at all, go for it!
Thanks for letting it happen, and for all the good stuff so far! :)

@nmielnik
Copy link
Member

nmielnik commented Feb 6, 2017

Merging this work in #1291 to be completed there. Thanks again @vendelin8

@nmielnik nmielnik closed this Feb 6, 2017
nmielnik added a commit that referenced this pull request Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants