Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow + char in URI path #2046

Merged
merged 2 commits into from
May 9, 2019
Merged

Allow + char in URI path #2046

merged 2 commits into from
May 9, 2019

Conversation

NizamLZ
Copy link
Contributor

@NizamLZ NizamLZ commented May 8, 2019 •
edited
Loading

Updated regex to allow + char in the path pathCharacterSet to resolve #2045

Issue first reported in vscode repository here

@NizamLZ NizamLZ changed the title Allow + char in URI path to resolve #2045 Allow + char in URI path May 8, 2019
@Tyriar Tyriar added this to the 3.14.0 milestone May 9, 2019
Tyriar
Tyriar approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try pull it into vscode soon, could be 1-2 weeks though.

@Tyriar Tyriar merged commit d363416 into xtermjs:master May 9, 2019
@Tyriar Tyriar mentioned this pull request May 10, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.

URL hyperlinking in console doesn't link full URL
2 participants
@NizamLZ @Tyriar