URL hyperlinking in console doesn't link full URL

[jkleec]

Issue Type: Bug

In the console, when a URL is displayed, you can ctrl/cmd click on it to open the link. However if the url contains a '+' character, it will stop parsing the URL at that point.

e.g.:

"http://my-gerrit-server.com/c/path/to/project/+/9906"

in this case, the URL that will be clickable is only:

"http://my-gerrit-server.com/c/path/to/project/"

VS Code version: Code 1.33.1 (51b0b28, 2019-04-11T08:22:55.268Z)
OS version: Darwin x64 18.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	16.00GB (0.70GB free)
Process Argv
Screen Reader	no
VM	33%

Extensions (39)

Extension	Author (truncated)	Version
angular-material	1to	0.13.0
logcat	abh	0.0.7
ng-template	Ang	0.1.11
angulardoc-vscode	Ang	6.1.3
path-intellisense	chr	1.4.2
angular-schematics	cyr	1.23.0
vscode-markdownlint	Dav	0.26.0
gitlens	eam	9.7.1
EditorConfig	Edi	0.13.0
prettier-vscode	esb	1.9.0
auto-close-tag	for	0.5.6
auto-rename-tag	for	0.0.15
json2ts	Gre	0.0.6
angular2-switcher	inf	0.2.0
Angular2	joh	7.1.5
angular-extension-pack	loi	0.7.1
Angular2Tests	Mar	0.7.3
Angular-BeastCode	Mik	8.0.6
python	ms-	2019.4.12954
cpptools	ms-	0.23.0-insiders2
csharp	ms-	1.19.0
vscode-typescript-tslint-plugin	ms-	1.0.0
debugger-for-chrome	msj	4.11.3
ng-fortytwo-vscode-extension	NG-	0.0.9
devicetree	plo	0.1.1
awesome-vhdl	puo	0.0.1
typescript-hero	rbb	3.0.0
java	red	0.44.0
jinjahtml	sam	0.10.2
simontest	Sim	1.3.3
autoimport	ste	1.5.3
move-ts	str	1.11.3
Angular2	UVB	0.4.1
vscodeintellicode	Vis	1.1.5
vscode-java-debug	vsc	0.18.0
vscode-java-dependency	vsc	0.4.0
vscode-java-pack	vsc	0.7.1
vscode-java-test	vsc	0.16.0
vscode-maven	vsc	0.16.2

[NizamLZ]

Can reproduce.

Looking into the issue.

[NizamLZ]

Issue is in xterm's regex

I added a new test for this case and it failed

[NizamLZ]

Submitted a PR to xterm