Throw on invalid entity #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogsie
force-pushed
the
throw-on-invalid-entity
branch
4 times, most recently
from
e92e660
to
4765f56
Compare
|
Rebased off master now that #125 was merged. I'm a bit conflicted as to if this should be considered a breaking change or not. It's a change that causes no change to how valid XML files are treated; it only causes invalid XML to be flagged. Any client code that relies on this incorrect usage should not rely on the incorrect usage, so I'm more inclined to include this as a bugfix rather than (as I previously was thinking) consider it as a breaking change... |
|
sounds like a bug fix to me, errors should be handled anyway |
This is more in line with standard XML parsers.
mogsie
force-pushed
the
throw-on-invalid-entity
branch
from
4765f56
to
b669efb
Compare
|
I removed the word (breaking) from the commit message to reflect that. \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws an error:
Illegal XML entity 'foobar'if it sees the text&foobar;.This is a breaking change, in that it changes the behaviour to be a standard. It can surely be described as a bugfix, because some might say that accepting invalid XML is a bug. The PR builds on #125 mainly because it changes the test introduced by #125, I wil happily rebase it if/when #125 is merged. The code change itself can be applied regardless of #125.