(breaking) Throw errors when invalid entities are encountered.

This is more in line with standard XML parsers.
xmppjs · Oct 1, 2018 · 4765f56 · 4765f56
1 parent 768df16
commit 4765f56
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/escape.js b/lib/escape.js
@@ -38,7 +38,10 @@ function unescapeXMLReplace (match) {
     }
     throw new Error('Illegal XML character 0x' + num.toString(16))
   }
-  return unescapeXMLTable[match] || match
+  if (unescapeXMLTable[match]) {
+    return unescapeXMLTable[match] || match
+  }
+  throw new Error('Illegal XML entity ' + match)
 }
 
 exports.escapeXML = function escapeXML (s) {

diff --git a/test/escape-test.js b/test/escape-test.js
@@ -49,8 +49,8 @@ vows.describe('escape').addBatch({
     'unescapes \'': function () {
       assert.strictEqual(unescapeXML('&apos;'), '\'')
     },
-    'leaves invalid entities alone': function () {
-      assert.strictEqual(unescapeXML('&foobar;'), '&foobar;')
+    'throws on invalid entities': function () {
+      assert.throws(() => unescapeXML('&foobar;'), Error, 'Illegal XML entity &foobar;')
     },
     'unescapes numeric entities': function () {
       assert.strictEqual(unescapeXML('&#64;'), '@')