Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cluster version update #590

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Dec 28, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Solve Refactor/curp client #581 (comment)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@iGxnon iGxnon marked this pull request as draft December 28, 2023 09:43
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 599 lines in your changes are missing coverage. Please review.

Comparison is base (fa656ad) 64.40% compared to head (79cb6a1) 77.06%.
Report is 33 commits behind head on master.

Files Patch % Lines
curp/src/client_new/unary.rs 0.00% 398 Missing ⚠️
curp/src/rpc/connect.rs 0.00% 76 Missing ⚠️
curp/src/client_new/mod.rs 0.00% 67 Missing ⚠️
xline/src/server/kv_server.rs 31.25% 22 Missing ⚠️
curp/src/rpc/mod.rs 84.48% 9 Missing ⚠️
xline-client/src/clients/kv.rs 78.57% 6 Missing ⚠️
xlineapi/src/command.rs 64.70% 6 Missing ⚠️
xline/src/server/command.rs 70.00% 3 Missing ⚠️
curp/src/client.rs 86.66% 2 Missing ⚠️
curp/src/server/raw_curp/mod.rs 96.92% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #590       +/-   ##
===========================================
+ Coverage   64.40%   77.06%   +12.66%     
===========================================
  Files         105      156       +51     
  Lines       18802    21812     +3010     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    16810     +4701     
+ Misses       5955     5002      -953     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon marked this pull request as ready for review December 28, 2023 10:20
@Phoenix500526 Phoenix500526 added this to the v0.6.1 milestone Dec 29, 2023
curp/src/server/raw_curp/tests.rs Show resolved Hide resolved
curp/src/members.rs Outdated Show resolved Hide resolved
curp/tests/it/server.rs Show resolved Hide resolved
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phoenix500526 Phoenix500526 merged commit 2cb678b into xline-kv:master Jan 2, 2024
8 of 9 checks passed
@iGxnon iGxnon deleted the fix/cluster-version branch January 10, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants