Refactor/curp client retry #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
===========================================
+ Coverage 64.40% 76.64% +12.24%
===========================================
Files 105 157 +52
Lines 18802 21927 +3125
Branches 18802 0 -18802
===========================================
+ Hits 12109 16806 +4697
+ Misses 5955 5121 -834
+ Partials 738 0 -738 ☔ View full report in Codecov by Sentry. |
bsbds
reviewed
Dec 25, 2023
iGxnon
force-pushed
the
refactor/curp-client-1
branch
4 times, most recently
from
9be5415
to
f43bb5f
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
Signed-off-by: iGxnon <igxnon@gmail.com>
iGxnon
force-pushed
the
refactor/curp-client-1
branch
2 times, most recently
from
27d869e
to
0bb0d0b
Compare
Signed-off-by: iGxnon <igxnon@gmail.com>
iGxnon
force-pushed
the
refactor/curp-client-1
branch
from
0bb0d0b
to
f62a6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #590
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add retry layer for curp client
what changes does this pull request make?
As above
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No