Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more things found by fuzzing #1630

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

YaLTeR
Copy link
Collaborator

@YaLTeR YaLTeR commented Sep 4, 2019

Leaving this as a draft because I want to collect more potential fixes from further fuzzing... Although currently both of my fuzzing runs are blocked on #1611.

Fixes #1631.

@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2019

Coverage Status

Coverage increased (+0.009%) to 71.136% when pulling 69c4df8 on YaLTeR:fix-more-things-2 into 1d62e4c on xiph:master.

@YaLTeR YaLTeR mentioned this pull request Sep 5, 2019
@lu-zero
Copy link
Collaborator

lu-zero commented Sep 10, 2019

This probably should be revisited now, the tests are still good though.

According to derf, it shouldn't be there.
@YaLTeR YaLTeR mentioned this pull request Sep 10, 2019
@YaLTeR YaLTeR marked this pull request as ready for review September 10, 2019 17:25
@YaLTeR
Copy link
Collaborator Author

YaLTeR commented Sep 10, 2019

Ready for review as nothing else was found.

@YaLTeR YaLTeR requested a review from lu-zero September 10, 2019 17:25
@YaLTeR YaLTeR merged commit f79a2f3 into xiph:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed in guess_frame_subtypes
4 participants