-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertion failed: sbo.0.x % (1 << sb_shift) == 0
since earlier this week
#1611
Comments
I think the test that was disabled here was catching this. |
This only happens when setting tile rows/cols to some value, at least setting both to 2 makes it happen. |
And also add support for forcing keyframes. Disable tiles in the test for now because of xiph/rav1e#1611
Reproducible with one tile with the following test: #[test]
fn get_units_region_assert() {
let config = Config {
enc: EncoderConfig {
width: 65,
height: 158,
bit_depth: 8,
chroma_sampling: ChromaSampling::Cs420,
chroma_sample_position: ChromaSamplePosition::Unknown,
pixel_range: PixelRange::Limited,
color_description: None,
mastering_display: None,
content_light: None,
still_picture: true,
time_base: Rational { num: 4294977800, den: 6004234345560342528 },
min_key_frame_interval: 12,
max_key_frame_interval: 240,
reservoir_frame_delay: None,
low_latency: true,
quantizer: 100,
min_quantizer: 0,
bitrate: 0,
tune: Tune::Psychovisual,
tile_cols: 0,
tile_rows: 0,
tiles: 0,
rdo_lookahead_frames: 0,
speed_settings: SpeedSettings {
min_block_size: BlockSize::BLOCK_64X64,
multiref: false,
fast_deblock: true,
reduced_tx_set: true,
tx_domain_distortion: true,
tx_domain_rate: false,
encode_bottomup: false,
rdo_tx_decision: false,
prediction_modes: PredictionModesSetting::Simple,
include_near_mvs: false,
no_scene_detection: true,
diamond_me: true,
cdef: true,
quantizer_rdo: false,
use_satd_subpel: false,
},
show_psnr: false,
train_rdo: false,
},
threads: 1,
};
let mut ctx: Context<u8> = config.new_context().unwrap();
ctx.send_frame(ctx.new_frame()).unwrap();
ctx.flush();
ctx.receive_packet().unwrap();
} Weird time base seems essential (1/25 doesn't trigger the assertion). EDIT: this triggers |
Weird time base seems essential (1/25 doesn't trigger the assertion).
wat.
Well, you have my attention, that's for sure.
I mean you had it, I am working on this 'right now' which means today
around other tasks.
Monty
|
The above example isn't one tile. There's three tiles stacked vertically. The framerate is causing the tiler to... overpartition. |
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
This patch set attempts to both improve cooperation between LRF and tiling setup, but also eliminate several illegal configurations. The patch strategy is to consistently eliminate evaluation of 'stretch' superblocks in RDO of LRUs for the loop restoration filter. This primarily affects the case where a tile consists of primarily/exclusively SBs that belong to an LRU stretched from some other tile.
If you run
cargo test
inhttps://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/tree/master/gst-plugin-rav1e
it will fail with panics
This was working fine with the version of rav1e on Tuesday.
The text was updated successfully, but these errors were encountered: