[AppKit] Add support for Xcode 15. #19119

mandel-macaque · 2023-10-02T21:36:44Z

This is a PR that supersedes: #18762

mandel-macaque · 2023-10-02T21:42:49Z

/azp run

azure-pipelines · 2023-10-02T21:43:01Z

Azure Pipelines successfully started running 1 pipeline(s).

src/appkit.cs

src/xkit.cs

rolfbjarne · 2023-10-10T08:49:34Z

src/xkit.cs

-		// This field is really inside WebKit
-		[NoWatch, NoTV]
-		[iOS (13, 0)]
-		[MacCatalyst (13, 1)]
-		[Field ("NSReadAccessURLDocumentOption", "WebKit")]
-		NSString NSReadAccessUrlDocumentOption { get; }


As stated in the original PR, I think it's best to leave this in:

#18762 (comment)

src/appkit.cs

Co-authored-by: Haritha Mohan <harithamohan@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2023-10-23T20:09:33Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T20:12:39Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T22:12:10Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0c8d3b539a32c4d4c998d524fb05e26175b09de4 [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T22:18:38Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-23T22:50:39Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0c8d3b539a32c4d4c998d524fb05e26175b09de4 [PR build]

vs-mobiletools-engineering-service2 · 2023-10-24T01:16:14Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0c8d3b539a32c4d4c998d524fb05e26175b09de4 [PR build]

mandel-macaque · 2023-10-24T01:39:59Z

/sudo backport release/8.0.xx

vs-mobiletools-engineering-service2 · 2023-10-24T01:40:39Z

Backport Job to branch release/8.0.xx Created! The magic is happening here

dalexsoto · 2023-10-24T07:45:01Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2023-10-24T07:45:47Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-10-24T07:47:27Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8583807 for more details.

dalexsoto · 2023-10-25T03:53:03Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2023-10-25T03:53:39Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-10-25T04:00:20Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8589855 for more details.

rolfbjarne · 2023-10-25T09:40:24Z

Backported manually: #19338

Backport of #19119. --------- Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

mandel-macaque requested review from rolfbjarne and dalexsoto as code owners October 2, 2023 21:36

This comment has been minimized.

Sign in to view

haritha-mohan requested changes Oct 2, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Oct 10, 2023

View reviewed changes

mandel-macaque and others added 2 commits October 13, 2023 10:59

[AppKit] Add support for Xcode 15.

c1d87be

Apply suggestions from code review

f47d14e

Co-authored-by: Haritha Mohan <harithamohan@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

mandel-macaque force-pushed the net8.0-xcode15-appkit branch from 113f914 to f47d14e Compare October 13, 2023 14:59

mandel-macaque requested review from emaf and mauroa as code owners October 13, 2023 14:59

mandel-macaque changed the base branch from net8.0-xcode15 to main October 13, 2023 15:01

This comment has been minimized.

Sign in to view

mandel-macaque added 2 commits October 16, 2023 17:37

Merge branch 'main' into net8.0-xcode15-appkit

03db542

Fix badly added change.

725d551

haritha-mohan approved these changes Oct 17, 2023

View reviewed changes

mandel-macaque added 4 commits October 19, 2023 09:52

Address reviews.

101ed88

Merge branch 'main' into net8.0-xcode15-appkit

a70b65a

Address reviews and fix some failing tests.

bbc0e6c

Merge branch 'main' into net8.0-xcode15-appkit

5aaf996

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-appkit

80fb208

This comment has been minimized.

Sign in to view

Undo mess from a merge.

0c8d3b5

rolfbjarne approved these changes Oct 23, 2023

View reviewed changes

mandel-macaque merged commit f9fb647 into main Oct 24, 2023
143 of 152 checks passed

dalexsoto deleted the net8.0-xcode15-appkit branch October 24, 2023 07:44

rolfbjarne pushed a commit to rolfbjarne/xamarin-macios that referenced this pull request Oct 25, 2023

[AppKit] Add support for Xcode 15. (xamarin#19119)

5aa3336

rolfbjarne mentioned this pull request Oct 25, 2023

[release/8.0.1xx] [AppKit] Add support for Xcode 15. #19338

Merged

dalexsoto pushed a commit that referenced this pull request Oct 25, 2023

[release/8.0.1xx] [AppKit] Add support for Xcode 15. (#19338)

8fec0a3

Backport of #19119. --------- Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

[AppKit] Add support for Xcode 15. #19119

[AppKit] Add support for Xcode 15. #19119

Conversation

mandel-macaque commented Oct 2, 2023

mandel-macaque commented Oct 2, 2023

azure-pipelines bot commented Oct 2, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Oct 10, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 23, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 23, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

vs-mobiletools-engineering-service2 commented Oct 23, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 23, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 23, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 24, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

mandel-macaque commented Oct 24, 2023

vs-mobiletools-engineering-service2 commented Oct 24, 2023

dalexsoto commented Oct 24, 2023

vs-mobiletools-engineering-service2 commented Oct 24, 2023

vs-mobiletools-engineering-service2 commented Oct 24, 2023

dalexsoto commented Oct 25, 2023

vs-mobiletools-engineering-service2 commented Oct 25, 2023

vs-mobiletools-engineering-service2 commented Oct 25, 2023

rolfbjarne commented Oct 25, 2023