Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
  • Loading branch information
@mandel-macaque @haritha-mohan @rolfbjarne
3 people committed Oct 13, 2023
1 parent c862bf6 commit 113f914
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
5 changes: 1 addition & 4 deletions src/appkit.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10721,7 +10721,7 @@ interface NSImageView : NSAccessibilityImage, NSMenuItemValidation {
[Export ("removeSymbolEffectOfType:options:animated:")]
void RemoveSymbolEffect (NSSymbolEffect symbolEffect, NSSymbolEffectOptions options, bool animated);

[NoiOS, Mac (14, 0)]
[Mac (14, 0)]
[Export ("removeAllSymbolEffects")]
void RemoveAllSymbolEffects ();

Expand Down Expand Up @@ -13398,7 +13398,6 @@ interface NSSavePanel {
[Mac (14, 0)]
[NullAllowed, Export ("identifier")]
string Identifier { get; set; }

}

#if !NET && !__MACCATALYST__
Expand Down Expand Up @@ -14702,7 +14701,6 @@ partial interface NSSpellChecker {
[NoMacCatalyst, Mac (14, 0)]
[Export ("showInlinePredictionForCandidates:client:")]
void ShowInlinePrediction (NSTextCheckingResult [] candidates, INSTextInputClient client);

}

[NoMacCatalyst]
Expand Down Expand Up @@ -16629,7 +16627,6 @@ partial interface NSView : NSDraggingDestination, NSAnimatablePropertyContainer,
[Mac (14, 0)]
[Export ("displayLinkWithTarget:selector:")]
CADisplayLink GetDisplayLink (NSObject target, Selector selector);

}

[NoMacCatalyst]
Expand Down
7 changes: 0 additions & 7 deletions src/xkit.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3629,13 +3629,6 @@ interface NSTextLayoutFragment : NSSecureCoding {
[Export ("frameForTextAttachmentAtLocation:")]
CGRect GetFrameForTextAttachment (INSTextLocation location);

[Internal]
[TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)]
[Export ("textLineFragmentForVerticalOffset:requiresExactMatch:")]
[return: NullAllowed]
NSTextLineFragment _GetTextLineFragment (nfloat verticalOffset, byte requiresExactMatch);

[Wrap ("_GetTextLineFragment (verticalOffset, requiresExactMatch ? (byte) 1 : (byte) 0)")]
[TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)]
[return: NullAllowed]
NSTextLineFragment GetTextLineFragment (nfloat verticalOffset, bool requiresExactMatch);
Expand Down

4 comments on commit 113f914

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build macOS tests'

Pipeline on Agent
Hash: 113f91459c1e0312e8fd79141a7d3b467c54c7a8 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build packages'

Pipeline on Agent
Hash: 113f91459c1e0312e8fd79141a7d3b467c54c7a8 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Detect API changes'

Pipeline on Agent
Hash: 113f91459c1e0312e8fd79141a7d3b467c54c7a8 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: 113f91459c1e0312e8fd79141a7d3b467c54c7a8 [CI build]

Please sign in to comment.