Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

If the element's renderer has already been nulled or disposed, request zero space for it #12114

Merged
merged 1 commit into from
Sep 16, 2020
Merged

If the element's renderer has already been nulled or disposed, request zero space for it #12114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Xamarin.Forms.Platform.Android/Platform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,9 +1335,13 @@ public static SizeRequest GetNativeSize(VisualElement view, double widthConstrai
{
Performance.Start(out string reference);

// FIXME: potential crash
IVisualElementRenderer visualElementRenderer = GetRenderer(view);

if (visualElementRenderer == null || visualElementRenderer.View.IsDisposed())
{
return new SizeRequest(Size.Zero, Size.Zero);
}

var context = visualElementRenderer.View.Context;

// negative numbers have special meanings to android they don't to us
Expand Down