This repository has been archived by the owner on May 1, 2024. It is now read-only.
If the element's renderer has already been nulled or disposed, request zero space for it #12114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t zero space for it fixes #10801
|
It is not the root of the problem, but it makes sense to avoid some disposed exceptions. |
rmarinho
approved these changes
Sep 15, 2020
PureWeen
approved these changes
Sep 16, 2020
samhouts
added
4.4.0
thisisthekap
pushed a commit
to thisisthekap/Xamarin.Forms
that referenced
this pull request
Oct 1, 2020
…t zero space for it (xamarin#12114) fixes xamarin#10801
thisisthekap
pushed a commit
to thisisthekap/Xamarin.Forms
that referenced
this pull request
Oct 7, 2020
…t zero space for it (xamarin#12114) fixes xamarin#10801
jfversluis
added a commit
that referenced
this pull request
Nov 29, 2021
2 tasks
jfversluis
added a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
While we still can't seem to reproduce #10801 under controlled conditions to find a root cause, it's clear that it's occurring when the platform attempts to measure a renderer which has already been disposed. These changes add a disposal check before rendering to avoid crashing; if the renderer has already been disposed, the method returns a size of zero.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Still can't reproduce the issue locally, so no tests at the moment.
PR Checklist