Fix android rich text errors #949

Tug · 2019-05-02T12:05:51Z

Gutenberg PR: WordPress/gutenberg#15392

This fixes RichText errors on merge and split.
Most of the work is in the GB PR.

Important fix in this PR:

We remove calls to clearSelectedBlock on focus that would reset the block selection and thus cause error in the MERGE_BLOCKS effect that need it initialized

Other fixes:

Refactor mergeBlocks in BlockHolder to be closer to the web version
Mock focusing RN elements for tests

Testing Instructions (on both Android and iOS)

Try splitting a header block
Try splitting a paragraph block
Try merging a paragraph block with a header block
Try merging 2 paragraph blocks
Try editing text into a paragraph or a header block
Try converting a selection into bold and/or italic
Try writing in bold
Try writing in italic
Try writing in both bold and italic
Try removing a format without selecting any text by having the cursor on formatted text and pressing on the selected format button
Try adding a link
Try converting a word to a link
Try copying a link and pasting it into a selection
Try copy pasting text

commit 72f934e Merge: c935c81 d46cebd Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu May 2 10:32:48 2019 +0300 Merge branch 'develop' into fix/list-handling-in-android commit c935c81 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu May 2 09:48:36 2019 +0300 Don't use a lambda, to avoid bringing in Java8 features commit d46cebd Merge: 42d8443 09f1ca7 Author: etoledom <etoledom@icloud.com> Date: Wed May 1 09:37:06 2019 +0200 Merge pull request #890 from wordpress-mobile/issue/autoscroll-on-list-block [iOS] Activate autoscroll on ListBlock commit 04610cc Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Wed May 1 00:56:33 2019 +0300 Need to include the kotlin plugin dep location commit 52832ce Merge: 897d272 42d8443 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Wed May 1 00:26:57 2019 +0300 Merge branch 'develop' into fix/list-handling-in-android commit 897d272 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Wed May 1 00:11:36 2019 +0300 Set Aztec t delete the Enter for paragraph block commit ca2a93f Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Tue Apr 30 20:24:28 2019 +0300 Update GB from its master commit 0417343 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Tue Apr 30 19:58:53 2019 +0300 Utilize isEnterPressedUnderway commit 991f8a8 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Tue Apr 30 18:10:09 2019 +0300 Use Aztec helper isEnterPressedUnderway commit 09f1ca7 Merge: 61b52cb 42d8443 Author: etoledom <etoledom@icloud.com> Date: Tue Apr 30 13:26:04 2019 +0200 Merge branch 'develop' into issue/autoscroll-on-list-block commit 61b52cb Author: etoledom <etoledom@icloud.com> Date: Tue Apr 30 13:25:10 2019 +0200 Update gutenberg ref to master commit 57c8de0 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Fri Apr 26 15:13:02 2019 +0300 Use a git tag to try please JitPack commit ab4f3e3 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Fri Apr 26 15:07:33 2019 +0300 Use shortened hash version to try please JitPack commit ce92f47 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Fri Apr 26 14:43:16 2019 +0300 Update Aztec ref commit 7897f98 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 16:07:12 2019 +0300 Update Aztec ref commit 76678c9 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 15:13:06 2019 +0300 Minimize diff commit cd97945 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 13:03:12 2019 +0300 Update GB hash commit c3f094a Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 12:44:16 2019 +0300 Update GB hash commit 7391049 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 12:02:19 2019 +0300 Update GB hash commit 70112bf Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 04:11:43 2019 +0300 Update GB hash commit 91c222e Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 03:21:56 2019 +0300 Update GB hash to use iOS regression fixes commit 1786fab Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 03:20:19 2019 +0300 Use simplified access to EnterPressedUnderway commit 166b206 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 03:15:37 2019 +0300 Remove temporary code commit d17e5d2 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 02:05:01 2019 +0300 Use Aztec ref with the Enter processing fix commit bbda142 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 02:00:41 2019 +0300 Use the GB hash with the rich-text fix commit 8889b8d Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Thu Apr 25 01:58:58 2019 +0300 Don't emit text changed event when Enter detected The Enter event (ReactAztecEnterEvent) will have the text that the RN side needs to process through the format-lib and hopefully match Aztec's processing. commit 38cdc59 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Tue Apr 23 11:54:54 2019 +0300 Use passed selection when Enter already altered text commit 2372231 Author: Stefanos Togkoulidis <stefanostogoulidis@gmail.com> Date: Tue Apr 23 10:11:51 2019 +0300 Signal if text has already been changed commit 1a4f344 Author: etoledom <etoledom@icloud.com> Date: Fri Apr 19 18:14:16 2019 +0200 Update gutenberg ref commit abc09d1 Merge: c6ca773 0be0fa2 Author: etoledom <etoledom@icloud.com> Date: Fri Apr 19 17:49:27 2019 +0200 Merge branch 'develop' into issue/autoscroll-on-list-block commit c6ca773 Author: etoledom <etoledom@icloud.com> Date: Fri Apr 19 17:49:17 2019 +0200 Update gutenberg ref commit a521284 Author: etoledom <etoledom@icloud.com> Date: Thu Apr 18 17:01:53 2019 +0200 Update gutenberg ref

peril-wordpress-mobile · 2019-05-02T12:05:55Z

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

…ext-errors

This reverts commit abeffb3.

hypest · 2019-05-09T07:58:25Z

Tried out 95f7d9a and there's an event loop happening (apparently). It happens in various cases when typing but managed to capture one when typing and deleting some text in a paragraph:

I think the "key" detail in order to replicate is to have some typing/deleting happening fast enough and then the issue arises.

etoledom · 2019-05-09T08:37:26Z

EDIT: Fixed by WordPress/gutenberg@cc12da7 and WordPress/gutenberg@1421cdd

Testing on iOS I found a strange behavior with the list block:

The list block doesn't get selected.
Pressing "Enter" in the list block, duplicates the content of the block.

I was able to reproduce the same behavior on Android.

daniloercoli · 2019-05-09T08:45:22Z

Tests run by using Google Board on my Nexus 5X running Android 7.1

Test 1
I was able to replicate a loop easily, just split a para block and start writing into it.

Test 2
I was able to replicate a "deleting loop" by tapping on a para block, start deleting content by tapping backspace and keep it pressed, then release the backspace key.

hypest · 2019-05-09T09:47:38Z

Steps to repro a merge problem:

Start with this initial html (empty content will do too):

<!-- wp:paragraph -->
<p>split, add a char in new para, backspace it and backspace again to merge</p>
<!-- /wp:paragraph -->

Put caret inside the split word and hit Enter to split the block
Type one char (e.g. g) at the start of the new block
Backspace to delete it
Backspace again to merge the blocks
Notice the g being there in the middle of the merged word/block

hypest · 2019-05-09T13:33:05Z

We've been working on some fixes and @etoledom and I have some commits to share. Will merge to this branch now.

daniloercoli · 2019-05-09T13:55:46Z

Undo doesn't work as expected.

Steps to repro:

Start the demo app
Put the caret in a para block, and tap Enter to split the block in two
Tap Undo ---> Boom!
The "original" block is back with the full content, but the block created after the splitting is not removed

etoledom · 2019-05-09T20:17:51Z

EDIT: Fixed by WordPress/gutenberg@86894ea

Found an issue on split (iOS and Android):

Steps to reproduce:

Select a paragraph block in the middle of the content.
Split the block.
Merge back the new block.
(Android) Split again.
- (iOS) Move the cursor and then Split again.
You will see that all the content stays in the first block.

daniloercoli · 2019-05-10T09:12:40Z

I noticed a minor(?) problem when trying to remove a block by tapping Backspace, and erasing all the content from it.
To reproduce the problem you can follow the steps below for simplicity, but I guess there are easier ways to reproduce it:

Start the demo app
On a para block tap enter and create a new block
Paste something in the block
Place the caret at the end of the block
Backspace to delete all the content
You will see that once the caret reached the beginning of the block, and the placeholder "Start Writing" is on the screen, you need to tap the Backspace 2 times to get the block deleted.

This seems like a minor issue, but better to not underestimate it, since it may uncover other issues we're missing from testing.

hypest · 2019-05-13T09:41:09Z

Will now merge the branches with the fixes I was working on over the last few days, so we can coordinate on a single branch/PR.

hypest · 2019-05-14T08:15:18Z

There's an undo bug where an extra character is appearing, which is a web-side issue. Tracked in WordPress/gutenberg#15619.

hypest · 2019-05-14T08:38:10Z

The undo issue reported by @daniloercoli in #949 (comment) is happening on the web too (I tried https://frontenberg.tomjn.com/ as well as local WP on GB hash eea04cf and happens there too) so, not a native mobile related issue.

koke · 2019-05-14T10:39:45Z

Not sure if it's a regression, but the moment you press backspace, the current format gets deselected:

koke · 2019-05-14T10:47:25Z

I found some odd things splitting lists and trying to undo the changes:

When you press enter at the beginning of the first item on a list, the content moves to a new item, and the first one remains empty. This is fine.
When you press backspace, the first empty item gets removed, but the list formatting is lost on the remaining item
Trying to undo the changes leaves just an empty list

marecar3 · 2019-05-14T17:45:25Z

...native-aztec/android/src/main/java/org/wordpress/mobile/ReactNativeAztec/ReactAztecText.java

@@ -84,6 +84,8 @@
    public ReactAztecText(ThemedReactContext reactContext) {
        super(reactContext);

+        setGutenbergMode(true);


Hey @Tug @hypest I have tried to test WPAndroid against this PR and it's crashing with this error: java.lang.NoSuchMethodError: No virtual method setGutenbergMode(Z)V in class Lorg/wordpress/mobile/ReactNativeAztec/ReactAztecText

...... I have realized that I forgot to update aztecVersion on WPAndroid, so everything is ok :)

etoledom · 2019-05-14T19:23:25Z

I found some odd things splitting lists and trying to undo the changes:

This seems to be fixed by: #973

Not sure if it's a regression, but the moment you press backspace, the current format gets deselected:

Just tested this and it's working good now! 🎉

EDIT: Fixed by WordPress/gutenberg@50527d3

With the last updates, I found a small issue on iOS: Sometimes the formats won't go away by pressing the format buttons.

It's easiest to reproduce in the lists block, but it also happens in paragraph. I couldn't reproduce it in Android, just iOS:

~~I can take a look at this.~~ Done.

etoledom · 2019-05-15T06:41:27Z

The format library doesn't seem to recognize bold with b tags, that's true for the web version too.
This means that our <p><b>Hello</b> World!</p> paragraph block in the initial example content is "buggy", but this issue is not generated in our end.

hypest

LGTM!

etoledom

Looks good!! 🎉

SergioEstevao

!

Tug added 4 commits May 2, 2019 13:12

Update gutenberg ref

da206d3

Retain cursor position on select

50c4652

REMOVE ME BEFORE MERGE: simplify initial html

abeffb3

Tug added the [Status] Not Ready For Review label May 2, 2019

Tug requested a review from etoledom May 2, 2019 12:05

Tug self-assigned this May 2, 2019

Tug added 9 commits May 2, 2019 14:10

Do not clear current block selection when adding a block

703a0a4

Update gutenberg ref

aeeb7ba

Simplify onSplit in BlockHolder and make it the same as the web version

d1d0b64

Update gutenberg ref

8dfb6f8

Merge remote-tracking branch 'origin/develop' into fix/android-rich-t…

2495469

…ext-errors

Update gutenberg ref

063d5bd

Update gutenberg ref

f7ed45f

Update gutenberg ref

1c2c67a

Fix CI tests

40a415b

Tug mentioned this pull request May 8, 2019

[RN Mobile] Fix crash when merging block WordPress/gutenberg#15392

Merged

Tug added 2 commits May 8, 2019 17:03

Mock focusing components on react native

cceace8

Revert "REMOVE ME BEFORE MERGE: simplify initial html"

95f7d9a

This reverts commit abeffb3.

Tug added bugfix and removed [Status] Not Ready For Review labels May 8, 2019

Update Gutenberg hash

9fe49e6

hypest and others added 5 commits May 13, 2019 12:45

Fix stray selection events from AztecAndroid

6556d28

Update GB hash

30d52c9

Update gutenberg ref

dead219

Update gutenberg ref

f1286ce

Update gutenberg ref

fde8338

Update from develop

d8a7253

etoledom mentioned this pull request May 14, 2019

[WIP] Fix crash on merging blocks. #942

Closed

marecar3 reviewed May 14, 2019

View reviewed changes

etoledom mentioned this pull request May 14, 2019

Rich Image Caption feature branch #975

Merged

Update gutenberg ref

e4d23fa

hypest mentioned this pull request May 15, 2019

Fix caret position after multi line paste #870

Closed

hypest approved these changes May 15, 2019

View reviewed changes

etoledom approved these changes May 15, 2019

View reviewed changes

Update gutenberg ref

a0240cd

SergioEstevao self-requested a review May 15, 2019 11:46

SergioEstevao approved these changes May 15, 2019

View reviewed changes

Tug merged commit dee8eca into develop May 15, 2019

Tug deleted the fix/android-rich-text-errors branch May 15, 2019 11:55

etoledom mentioned this pull request May 15, 2019

Editor crashes on merging blocks #921

Closed

hypest mentioned this pull request May 16, 2019

Use AztecAndroid's v1.3.27 tag #983

Merged

mkevins mentioned this pull request May 27, 2019

Merging blocks after split causes crash #1034

Closed

jd-alexander mentioned this pull request Mar 11, 2021

[RNMobile] Try fixing split/merge issue on native mobile by dropping selection update event when late WordPress/gutenberg#29683

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix android rich text errors #949

Fix android rich text errors #949

Tug commented May 2, 2019 •

edited

Loading

peril-wordpress-mobile bot commented May 2, 2019

hypest commented May 9, 2019

etoledom commented May 9, 2019 •

edited

Loading

daniloercoli commented May 9, 2019

hypest commented May 9, 2019 •

edited

Loading

hypest commented May 9, 2019

daniloercoli commented May 9, 2019

etoledom commented May 9, 2019 •

edited

Loading

daniloercoli commented May 10, 2019

hypest commented May 13, 2019

hypest commented May 14, 2019

hypest commented May 14, 2019

koke commented May 14, 2019

koke commented May 14, 2019 •

edited

Loading

marecar3 May 14, 2019 •

edited

Loading

etoledom commented May 14, 2019 •

edited

Loading

etoledom commented May 15, 2019

hypest left a comment

etoledom left a comment

SergioEstevao left a comment

Fix android rich text errors #949

Fix android rich text errors #949

Conversation

Tug commented May 2, 2019 • edited Loading

Testing Instructions (on both Android and iOS)

peril-wordpress-mobile bot commented May 2, 2019

hypest commented May 9, 2019

etoledom commented May 9, 2019 • edited Loading

daniloercoli commented May 9, 2019

hypest commented May 9, 2019 • edited Loading

hypest commented May 9, 2019

daniloercoli commented May 9, 2019

etoledom commented May 9, 2019 • edited Loading

daniloercoli commented May 10, 2019

hypest commented May 13, 2019

hypest commented May 14, 2019

hypest commented May 14, 2019

koke commented May 14, 2019

koke commented May 14, 2019 • edited Loading

marecar3 May 14, 2019 • edited Loading

Choose a reason for hiding this comment

etoledom commented May 14, 2019 • edited Loading

etoledom commented May 15, 2019

hypest left a comment

Choose a reason for hiding this comment

etoledom left a comment

Choose a reason for hiding this comment

SergioEstevao left a comment

Choose a reason for hiding this comment

Tug commented May 2, 2019 •

edited

Loading

etoledom commented May 9, 2019 •

edited

Loading

hypest commented May 9, 2019 •

edited

Loading

etoledom commented May 9, 2019 •

edited

Loading

koke commented May 14, 2019 •

edited

Loading

marecar3 May 14, 2019 •

edited

Loading

etoledom commented May 14, 2019 •

edited

Loading