Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor crashes on merging blocks #921

Closed
pinarol opened this issue Apr 23, 2019 · 2 comments
Closed

Editor crashes on merging blocks #921

pinarol opened this issue Apr 23, 2019 · 2 comments
Assignees
@Tug @etoledom
Labels
[Type] Bug Something isn't working Writing Flow

Comments

@pinarol
Copy link
Contributor

pinarol commented Apr 23, 2019 •
edited
Loading

Steps to introduce:

Open the editor and change the content as:

<!-- wp:paragraph -->
<p><b>Hello</b> World!</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>part two</p>
<!-- /wp:paragraph -->

Switch to visual mode and try to merge 2 blocks
Following crash occurs:

Cannot read property 'multiline' of undefined

Array.MERGE_BLOCKS
    effects.js:93:62
Object.dispatch
    refx.js:37:38
Object.mergeBlocks
    index.js:191:32
ComponentWithDispatch.proxyDispatch
    index.js:94:4
BlockHolder._this.mergeBlocks
    block-holder.js:156:3
RichText.onBackspace
    index.native.js:332:3
RichText.proxiedMethod
    createPrototypeProxy.js:44:29
AztecView._this._onBackspace
    AztecView.js:72:4
Object.invokeGuardedCallbackImpl
    ReactNativeRenderer-dev.js:93:9
invokeGuardedCallback
    ReactNativeRenderer-dev.js:318:30
@pinarol pinarol added [Type] Bug Something isn't working Writing Flow labels Apr 23, 2019
@pinarol pinarol self-assigned this Apr 23, 2019
@pinarol pinarol added this to the v1.4 milestone Apr 23, 2019
@pinarol pinarol removed their assignment Apr 23, 2019
@pinarol pinarol mentioned this issue Apr 23, 2019
Merged
5 tasks
@etoledom etoledom mentioned this issue Apr 29, 2019
Closed
@hypest
Copy link
Contributor

hypest commented May 3, 2019

This is an important issue and we'll continue working on it on the next milestone. In the meantime, for v1.4 we have "extracted" from Gutenberg the code that causes the breakage by using a branch off Gutenberg's master that doesn't include it. See WordPress/gutenberg#15399.

Bumping this to the next milestone.

@hypest hypest modified the milestones: v1.4, v1.5 May 3, 2019
@etoledom etoledom removed this from the v1.5 milestone May 15, 2019
@etoledom
Copy link
Contributor

Fixed via :#949 (🎉)

@mkevins mkevins mentioned this issue May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tug Tug

@etoledom etoledom

Labels
[Type] Bug Something isn't working Writing Flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Mobile]: Fix crash on merge. (WIP) WordPress/gutenberg
4 participants
@Tug @hypest @pinarol @etoledom