[RN Mobile] Fix crash when merging block #15392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
dmsnell,
ellatrix,
gziolo,
jorgefilipecosta,
karmatosed,
mapk,
mkaz,
mmtr,
nerrad,
noisysocks,
oandregal,
notnownikki,
ntwb,
Soean,
swissspidy,
talldan and
youknowriad
as code owners
|
Hey just a couple friendly reminders:
|
Tug
force-pushed
the
rnmobile/fix-crash-on-merge-2
branch
from
6d06bcd
to
9b93e9b
Compare
Pressing on the buttons didn't change the format of the selected text.
…/fix-crash-on-merge-2
| @@ -343,6 +391,8 @@ export class RichText extends Component { | |||
| if ( onRemove && empty && isReverse ) { | |||
| onRemove( ! isReverse ); | |||
| } | |||
|
|
|||
| event.preventDefault(); | |||
There was a problem hiding this comment.
Does this make sense on RN?
There was a problem hiding this comment.
Not really indeed.
I don't think it's doing anything at the moment (it probably could if we handled it on the native side?), I just added it because I wanted the code to get closer to the RichText web version so we can merge the two in the short term.
If you find it confusing I don't mind removing it.
There was a problem hiding this comment.
It's ok for me, it will actually be nice that this sent something back to the native side, and then we could decide how to handle the Enter/Delete after JS processed the event.
…es won't change the format of the selected text
Tug
added
Mobile App - i.e. Android or iOS
7 tasks
This was referenced Oct 16, 2024
[Snyk] Upgrade @wordpress/postcss-plugins-preset from 1.6.0 to 5.8.1
WontonSam/woocommerce-admin#431
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade RichText on mobile native to use the latest changes from the web, mainly those made in #14640
It also removes the customization we made to the rich-text library since writing in multiple formats at once is now stable on the web.
Testing Instructions
Tested with wordpress-mobile/gutenberg-mobile#949